Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2039873002: [gn] Fix isolate_driver for gn (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Fix isolate_driver for gn This makes the isolate-driver script rebase all paths to be relative to the isolate-file location. This is an assumption of the go binaries and is needed for batcharchive to work. In gyp, actions were executed relative to the gyp file that specified them, while in gn it's relative to the product dir. BUG=chromium:474921 Committed: https://crrev.com/87affbc531b1b28d27d38075ec0fd9d0a2037e4a Cr-Commit-Position: refs/heads/master@{#36746}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M gni/isolate.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/isolate_driver.py View 1 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039873002/1
4 years, 6 months ago (2016-06-06 12:20:34 UTC) #2
Michael Achenbach
PTAL
4 years, 6 months ago (2016-06-06 12:25:00 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 12:49:31 UTC) #9
tandrii(chromium)
lgtm https://codereview.chromium.org/2039873002/diff/1/tools/isolate_driver.py File tools/isolate_driver.py (right): https://codereview.chromium.org/2039873002/diff/1/tools/isolate_driver.py#newcode67 tools/isolate_driver.py:67: os.chdir(new_base) assert(os.path.basename(args[isolate]) == args[isolate])
4 years, 6 months ago (2016-06-06 12:54:33 UTC) #10
Michael Achenbach
Done
4 years, 6 months ago (2016-06-06 12:57:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039873002/20001
4 years, 6 months ago (2016-06-06 12:58:10 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 13:24:51 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 13:25:13 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/87affbc531b1b28d27d38075ec0fd9d0a2037e4a
Cr-Commit-Position: refs/heads/master@{#36746}

Powered by Google App Engine
This is Rietveld 408576698