third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp - Issue 2039863002: PaymentRequest: Sync up PaymentAddress with the payment request spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp

Issue 2039863002: PaymentRequest: Sync up PaymentAddress with the payment request spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentsValidators.h ('k') | third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp b/third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp

index 0d5e65704cdff627b33b3e88f4a658fde9470012..ca7e0d04fe099047d5b8f7abd15bdf855172977a 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp

@@ -31,7 +31,7 @@ bool PaymentsValidators::isValidAmountFormat(const String& amount, String* optio

return false;

}

-bool PaymentsValidators::isValidRegionCodeFormat(const String& code, String* optionalErrorMessage)

+bool PaymentsValidators::isValidCountryCodeFormat(const String& code, String* optionalErrorMessage)

{

if (ScriptRegexp("^[A-Z]{2}$", TextCaseSensitive).match(code) == 0)

return true;

@@ -66,7 +66,7 @@ bool PaymentsValidators::isValidScriptCodeFormat(const String& code, String* opt

bool PaymentsValidators::isValidShippingAddress(const mojom::blink::PaymentAddressPtr& address, String* optionalErrorMessage)

{

- if (!isValidRegionCodeFormat(address->region_code, optionalErrorMessage))

+ if (!isValidCountryCodeFormat(address->country, optionalErrorMessage))

return false;

if (!isValidLanguageCodeFormat(address->language_code, optionalErrorMessage))