third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp - Issue 2039863002: PaymentRequest: Sync up PaymentAddress with the payment request spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

Issue 2039863002: PaymentRequest: Sync up PaymentAddress with the payment request spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentAddressTest.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentsValidators.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

index bc9af1a275f4aaa67d1e7b83e3573fbc680bd556..55d8e064f0452b21a6b77fc6be921920cb1f5dcb 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

@@ -269,7 +269,7 @@ TEST_F(PaymentRequestTest, RejectShowPromiseWithRequestShippingFalseAndShippingA

PaymentRequest* request = PaymentRequest::create(getScriptState(), Vector<String>(1, "foo"), buildPaymentDetailsForTest(), options, getExceptionState());

EXPECT_FALSE(getExceptionState().hadException());

mojom::blink::PaymentAddressPtr shippingAddress = mojom::blink::PaymentAddress::New();

- shippingAddress->region_code = "US";

+ shippingAddress->country = "US";

shippingAddress->language_code = "en";

shippingAddress->script_code = "Latn";

@@ -287,7 +287,7 @@ TEST_F(PaymentRequestTest, ResolveShowPromiseWithRequestShippingTrueAndValidShip

EXPECT_FALSE(getExceptionState().hadException());

mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();

response->shipping_address = mojom::blink::PaymentAddress::New();

- response->shipping_address->region_code = "US";

+ response->shipping_address->country = "US";

response->shipping_address->language_code = "en";

response->shipping_address->script_code = "Latn";

@@ -298,7 +298,7 @@ TEST_F(PaymentRequestTest, ResolveShowPromiseWithRequestShippingTrueAndValidShip

v8::MicrotasksScope::PerformCheckpoint(getScriptState()->isolate());

PaymentResponse* pr = V8PaymentResponse::toImplWithTypeCheck(getScriptState()->isolate(), outValue.v8Value());

- EXPECT_EQ("US", pr->shippingAddress()->regionCode());

+ EXPECT_EQ("US", pr->shippingAddress()->country());

EXPECT_EQ("en-Latn", pr->shippingAddress()->languageCode());

}