Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentAddress.idl

Issue 2039863002: PaymentRequest: Sync up PaymentAddress with the payment request spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentAddress.idl
diff --git a/third_party/WebKit/Source/modules/payments/PaymentAddress.idl b/third_party/WebKit/Source/modules/payments/PaymentAddress.idl
index cf9decab6d913b56729f87b0962cbe9d2356275d..df73644b0c647951776def6506f14c3c9256434e 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentAddress.idl
+++ b/third_party/WebKit/Source/modules/payments/PaymentAddress.idl
@@ -7,14 +7,20 @@
[
RuntimeEnabled=PaymentRequest,
] interface PaymentAddress {
- readonly attribute DOMString regionCode;
+ readonly attribute DOMString country;
+ // TODO(zino): Should use FrozenArray<> instead of sequence<>.
+ // However, we can't use it in modules because current implementation
+ // causes link error. So, we use sequence<> instead for now.
+ // Please see: https://crbug.com/617919
readonly attribute sequence<DOMString> addressLine;
zino 2016/06/07 12:27:53 When using FrozenArray type, link error occurs in
zino 2016/06/07 12:47:14 Sorry, I've just gotten lgtm from bash1@. (https:/
- readonly attribute DOMString administrativeArea;
- readonly attribute DOMString locality;
+ readonly attribute DOMString region;
+ readonly attribute DOMString city;
readonly attribute DOMString dependentLocality;
readonly attribute DOMString postalCode;
readonly attribute DOMString sortingCode;
readonly attribute DOMString languageCode;
readonly attribute DOMString organization;
readonly attribute DOMString recipient;
+ readonly attribute DOMString careOf;
+ readonly attribute DOMString phone;
};

Powered by Google App Engine
This is Rietveld 408576698