Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2039853004: Replace ui::LatencyInfo::InputCoordinate with gfx::PointF (Closed)

Created:
4 years, 6 months ago by Fady Samuel
Modified:
4 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, tdresser+watch_chromium.org, viettrungluu+watch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ui::LatencyInfo::InputCoordinate with gfx::PointF This reduces code duplication and makes the world a happier place. BUG=611802 TBR=ben@chromium.org Committed: https://crrev.com/cc016ede169b3f1a9d7153a27eadd6d8ead52e1a Committed: https://crrev.com/ac64128a4ca6529e861813159ef5852fcc304614 Cr-Original-Commit-Position: refs/heads/master@{#398278} Cr-Commit-Position: refs/heads/master@{#398328}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fix broken fuzzer #

Patch Set 4 : Remove extraneous fuzztraits #

Patch Set 5 : Add gfx_ipc_geometry dep in gyp #

Patch Set 6 : Add geometry ipc dep to unit test #

Patch Set 7 : Added missing gyp dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -144 lines) Patch
M content/browser/renderer_host/input/render_widget_host_latency_tracker.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/fuzzer.cc View 1 2 3 2 chunks +1 line, -14 lines 0 comments Download
M ui/events/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/events.gyp View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/events_unittests.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/ipc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/ipc/latency_info_param_traits.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/ipc/latency_info_param_traits_macros.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/events/ipc/latency_info_param_traits_unittest.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M ui/events/latency_info.h View 4 chunks +4 lines, -13 lines 0 comments Download
M ui/events/latency_info.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M ui/events/mojo/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ui/events/mojo/latency_info.mojom View 2 chunks +2 lines, -8 lines 0 comments Download
M ui/events/mojo/latency_info.typemap View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/mojo/latency_info_struct_traits.h View 1 2 3 4 1 chunk +3 lines, -19 lines 0 comments Download
M ui/events/mojo/latency_info_struct_traits.cc View 1 2 3 4 2 chunks +9 lines, -10 lines 0 comments Download
M ui/events/mojo/struct_traits_unittest.cc View 4 chunks +7 lines, -27 lines 0 comments Download
M ui/events/mojo/traits_test_service.mojom View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 52 (28 generated)
Fady Samuel
4 years, 6 months ago (2016-06-06 22:01:02 UTC) #2
Fady Samuel
+tsepez@ for ipc / mojo dirs
4 years, 6 months ago (2016-06-06 23:02:12 UTC) #4
Tom Sepez
lgtm
4 years, 6 months ago (2016-06-06 23:08:02 UTC) #5
sadrul
Thanks! lgtm
4 years, 6 months ago (2016-06-07 03:06:54 UTC) #6
Fady Samuel
+ben@: TBR'ing for the content part of this cleanup! Thanks
4 years, 6 months ago (2016-06-07 03:12:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039853004/1
4 years, 6 months ago (2016-06-07 03:12:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/17018) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-07 03:14:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039853004/10001
4 years, 6 months ago (2016-06-07 03:47:10 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/199288)
4 years, 6 months ago (2016-06-07 04:13:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039853004/30001
4 years, 6 months ago (2016-06-07 04:36:34 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/212160) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 6 months ago (2016-06-07 04:55:37 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039853004/50001
4 years, 6 months ago (2016-06-07 04:58:51 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/215082)
4 years, 6 months ago (2016-06-07 05:23:27 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039853004/70001
4 years, 6 months ago (2016-06-07 10:25:58 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039853004/90001
4 years, 6 months ago (2016-06-07 10:55:34 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/83143)
4 years, 6 months ago (2016-06-07 11:56:59 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039853004/90001
4 years, 6 months ago (2016-06-07 12:03:30 UTC) #38
commit-bot: I haz the power
Committed patchset #6 (id:90001)
4 years, 6 months ago (2016-06-07 12:40:02 UTC) #40
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/cc016ede169b3f1a9d7153a27eadd6d8ead52e1a Cr-Commit-Position: refs/heads/master@{#398278}
4 years, 6 months ago (2016-06-07 12:41:43 UTC) #42
Geoff Lang
A revert of this CL (patchset #6 id:90001) has been created in https://codereview.chromium.org/2048673002/ by geofflang@chromium.org. ...
4 years, 6 months ago (2016-06-07 15:42:30 UTC) #43
Fady Samuel
On 2016/06/07 15:42:30, Geoff Lang wrote: > A revert of this CL (patchset #6 id:90001) ...
4 years, 6 months ago (2016-06-07 16:10:27 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039853004/110001
4 years, 6 months ago (2016-06-07 16:32:22 UTC) #48
commit-bot: I haz the power
Committed patchset #7 (id:110001)
4 years, 6 months ago (2016-06-07 17:49:45 UTC) #50
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 17:50:57 UTC) #52
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/ac64128a4ca6529e861813159ef5852fcc304614
Cr-Commit-Position: refs/heads/master@{#398328}

Powered by Google App Engine
This is Rietveld 408576698