Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 2039843003: [arm] Support float registers for moves and swaps. (Closed)

Created:
4 years, 6 months ago by bbudge
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Support float registers for moves and swaps. Uses float registers s0-s31 for moves and swaps when rep is kFloat32. Changes bitcast to use float registers. LOG=N BUG=v8:4124 Committed: https://crrev.com/9eb756fb30704606dbb477791758b017f5b5dc2b Cr-Commit-Position: refs/heads/master@{#36791}

Patch Set 1 #

Patch Set 2 : Use __ Move to eliminate pointless moves. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -34 lines) Patch
M src/arm/macro-assembler-arm.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 3 chunks +90 lines, -32 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/instruction-scheduler-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
bbudge
4 years, 6 months ago (2016-06-06 19:36:58 UTC) #2
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-07 03:46:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039843003/40001
4 years, 6 months ago (2016-06-07 13:59:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-07 14:01:27 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 14:04:41 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9eb756fb30704606dbb477791758b017f5b5dc2b
Cr-Commit-Position: refs/heads/master@{#36791}

Powered by Google App Engine
This is Rietveld 408576698