New tests for initializing formal access.

New tests for initializing formal access.

This CL adds tests for previously uncovered elements of the semantics
and includes fixes such that the desired behavior is obtained. In
particular, an `isInitializingFormal` element may now occur in contexts
where it wasn't expected until now, and changes were made to handle it.
It is also checked that a capture of an initializing formal (in a
function literal) captures the parameter, not the field.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/543a51ff3eb1488e2c1938bfcd8779f0d634900c

[eernst, 2016-06-06 08:22:41]

eernst@google.com changed reviewers:
+ johnniwinther@google.com

[eernst, 2016-06-06 08:22:42]

Missing test cases + impl for `this.x` access.

Note that I haven't added any tests to
tests/compiler/dart2js/type_checker_test.dart about promotion and
missing-promotion situations, I need to clarify that.

[Johnni Winther, 2016-06-06 09:23:08]

lgtm

https://codereview.chromium.org/2039833002/diff/20001/tests/language/initiali...
File tests/language/initializing_formal_promotion_test.dart (right):

https://codereview.chromium.org/2039833002/diff/20001/tests/language/initiali...
tests/language/initializing_formal_promotion_test.dart:17: if (x is A) y = x;
Maybe add a test for `x.x` with expected static type warning for this case?

[floitsch, 2016-06-06 10:33:23]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2016-06-06 10:33:24]

DBC.

https://codereview.chromium.org/2039833002/diff/20001/tests/language/initiali...
File tests/language/initializing_formal_final_test.dart (right):

https://codereview.chromium.org/2039833002/diff/20001/tests/language/initiali...
tests/language/initializing_formal_final_test.dart:19: Expect.throws(() =>
a.y(), (e) => e is Error);
No need for the second argument, if you don't check for a specific type.

[eernst, 2016-06-06 11:01:44]

Review response. Catching up with Johnni about the multi/options conflict.

https://codereview.chromium.org/2039833002/diff/20001/tests/language/initiali...
File tests/language/initializing_formal_final_test.dart (right):

https://codereview.chromium.org/2039833002/diff/20001/tests/language/initiali...
tests/language/initializing_formal_final_test.dart:19: Expect.throws(() =>
a.y(), (e) => e is Error);
On 2016/06/06 10:33:24, floitsch wrote:
> No need for the second argument, if you don't check for a specific type.

It was too unspecific, we can actually test for `NoSuchMethodError`. Doing that
now.

https://codereview.chromium.org/2039833002/diff/20001/tests/language/initiali...
File tests/language/initializing_formal_promotion_test.dart (right):

https://codereview.chromium.org/2039833002/diff/20001/tests/language/initiali...
tests/language/initializing_formal_promotion_test.dart:17: if (x is A) y = x;
On 2016/06/06 09:23:08, Johnni Winther wrote:
> Maybe add a test for `x.x` with expected static type warning for this case?

Sounds like we need a combination of multi-testing and `DartOptions`, but that
is not supported (https://github.com/dart-lang/sdk/issues/26506). Let's discuss
this IRL a bit.

[eernst, 2016-06-06 11:01:47]

Review response. Catching up with Johnni about the multi/options conflict.

[eernst, 2016-06-06 13:55:53]

Description was changed from

==========
New tests for initializing formal access.

This CL adds tests for previously uncovered elements of the semantics
and includes fixes such that the desired behavior is obtained. In
particular, an `isInitializingFormal` element may now occur in contexts
where it wasn't expected until now, and changes were made to handle it.
It is also checked that a capture of an initializing formal (in a
function literal) captures the parameter, not the field.
==========

to

==========
New tests for initializing formal access.

This CL adds tests for previously uncovered elements of the semantics
and includes fixes such that the desired behavior is obtained. In
particular, an `isInitializingFormal` element may now occur in contexts
where it wasn't expected until now, and changes were made to handle it.
It is also checked that a capture of an initializing formal (in a
function literal) captures the parameter, not the field.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/543a51ff3eb1488e2c1938bfcd8779f0d634900c
==========

[eernst, 2016-06-06 13:55:54]

Committed patchset #3 (id:40001) manually as
543a51ff3eb1488e2c1938bfcd8779f0d634900c (presubmit successful).