chrome/chrome_tests.gypi - Issue 2039823002: MacViews: Refactor certificate viewer tests to work for MacViews browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_tests.gypi

Issue 2039823002: MacViews: Refactor certificate viewer tests to work for MacViews browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@certview

Patch Set: Rebase onto master & add ignoreMouseEvents fix for hiding/reshowing the certificate viewer. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm ('K') | « chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_tests.gypi

diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi

index 91eb0f02f9b932a670e12bcbe919259adfc3d1aa..898f574788cbaef4ac9bd607110fbd57a07bd137 100644

--- a/chrome/chrome_tests.gypi

+++ b/chrome/chrome_tests.gypi

@@ -598,6 +598,12 @@

'test/ppapi/ppapi_browsertest.cc',

'test/ppapi/ppapi_filechooser_browsertest.cc',

+ # Tests for Mac only (Cocoa and mac_views_browser=1).

+ 'chrome_browser_tests_mac_sources': [

+ 'browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm',

+ 'browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc',

+ 'browser/ui/cocoa/certificate_viewer_mac_browsertest.mm',

+ ],

# Tests corresponding to the files in chrome_browser_ui_cocoa_sources.

# Built on Mac, except when mac_views_browser==1.

'chrome_browser_tests_cocoa_sources': [

@@ -608,7 +614,6 @@

'browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm',

'browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm',

'browser/ui/cocoa/browser_window_controller_browsertest.mm',

- 'browser/ui/cocoa/certificate_viewer_mac_browsertest.mm',

'browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm',

'browser/ui/cocoa/content_settings/collected_cookies_mac_browsertest.mm',

'browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm',

@@ -2548,10 +2553,7 @@

'../components/components.gyp:breakpad_stubs',

'../third_party/ocmock/ocmock.gyp:ocmock',

- 'sources': [

- 'browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm',

- 'browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc',

- ],

+ 'sources': [ '<@(chrome_browser_tests_mac_sources)' ],

'sources!': [

# TODO(groby): This test depends on hunspell and we cannot run it on

# Mac, which does not use hunspell by default.