Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2039813006: We hard coded the pointer type as mouse in ui::GetMousePointerDetailsFromNative for events sending … (Closed)

Created:
4 years, 6 months ago by lanwei
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

We hard coded the pointer type as mouse in ui::GetMousePointerDetailsFromNative for events sending from Windows. Now we use a mouse message from GetMessageExtraInfo to decide the actual input device type. GetMessageExtraInfo needs to be mask-checked against 0xFFFFFF00, and then compared with 0xFF515700. True when this mouse message was generated by a Tablet PC pen or touch screen. Otherwise it is from a mouse device. Additionally, in Windows Vista or later, the eighth bit, masked by 0x80, is used to differentiate touch input from pen input (0 = pen, 1 = touch). Reference: https://msdn.microsoft.com/en-us/library/windows/desktop/ms703320(v=vs.85).aspx BUG=614820 Review-Url: https://codereview.chromium.org/2020143003 Cr-Commit-Position: refs/heads/master@{#398025} (cherry picked from commit 16ac979eddbdd5ccc045092c1260e42dd38191f6) Committed: https://chromium.googlesource.com/chromium/src/+/6f7dbeb652323de923942b2956ea12d81187894e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M ui/events/win/events_win.cc View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
lanwei
4 years, 6 months ago (2016-06-08 15:15:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f7dbeb652323de923942b2956ea12d81187894e.

Powered by Google App Engine
This is Rietveld 408576698