Chromium Code Reviews| Index: ui/gfx/native_pixmap_handle_ozone.h |
| diff --git a/ui/gfx/native_pixmap_handle_ozone.h b/ui/gfx/native_pixmap_handle_ozone.h |
| index 3672feca1cab3bac6d9e7dd2676353ff488e821d..1e736361372fb33e99f9b49ad8affc12d8e5491f 100644 |
| --- a/ui/gfx/native_pixmap_handle_ozone.h |
| +++ b/ui/gfx/native_pixmap_handle_ozone.h |
| @@ -13,6 +13,19 @@ |
| namespace gfx { |
| +struct GFX_EXPORT GbmBufferPlane { |
|
Daniele Castagna
2016/06/15 03:50:20
Comment before struct definition.
vinceh
2016/06/15 04:35:18
Will fix.
|
| + GbmBufferPlane(); |
| + GbmBufferPlane(int stride, int offset, uint64_t modifier); |
| + GbmBufferPlane(const GbmBufferPlane& other); |
| + ~GbmBufferPlane(); |
| + |
| + // The strides and offsets in bytes to be used when accessing the buffers via |
| + // a memory mapping. One per plane per entry. |
| + int stride; |
| + int offset; |
| + uint64_t modifier; |
|
Daniele Castagna
2016/06/15 03:50:20
nit: I think the modifier deserves a comment as we
vinceh
2016/06/15 04:35:18
Yes, will add.
|
| +}; |
| + |
| struct GFX_EXPORT NativePixmapHandle { |
| NativePixmapHandle(); |
| NativePixmapHandle(const NativePixmapHandle& other); |
| @@ -21,9 +34,7 @@ struct GFX_EXPORT NativePixmapHandle { |
| // File descriptors for the underlying memory objects (usually dmabufs). |
| std::vector<base::FileDescriptor> fds; |
| - // The strides and offsets in bytes to be used when accessing the buffers via |
| - // a memory mapping. One per plane per entry. |
| - std::vector<std::pair<int, int>> strides_and_offsets; |
| + std::vector<GbmBufferPlane> planes; |
| }; |
| } // namespace gfx |