Add format modifier IDs for EGL_EXT_image_dma_buf_import extension

ui/gl/gl_image_ozone_native_pixmap.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/buffer_format_util.h"
 #include "ui/gl/gl_image_ozone_native_pixmap.h"
 
 #define FOURCC(a, b, c, d)                                        \
   ((static_cast<uint32_t>(a)) | (static_cast<uint32_t>(b) << 8) | \
    (static_cast<uint32_t>(c) << 16) | (static_cast<uint32_t>(d) << 24))
@@ skipping 111 matching lines @@
     attrs.push_back(EGL_WIDTH);
     attrs.push_back(size_.width());
     attrs.push_back(EGL_HEIGHT);
     attrs.push_back(size_.height());
     attrs.push_back(EGL_LINUX_DRM_FOURCC_EXT);
     attrs.push_back(FourCC(format));
 
     for (size_t plane = 0;
          plane < gfx::NumberOfPlanesForBufferFormat(pixmap->GetBufferFormat());
          ++plane) {
+      uint64_t modifier = pixmap->GetDmaBufModifier(plane);
       attrs.push_back(EGL_DMA_BUF_PLANE0_FD_EXT + plane * 3);
       attrs.push_back(pixmap->GetDmaBufFd(plane));
       attrs.push_back(EGL_DMA_BUF_PLANE0_OFFSET_EXT + plane * 3);
       attrs.push_back(0);
       attrs.push_back(EGL_DMA_BUF_PLANE0_PITCH_EXT + plane * 3);
       attrs.push_back(pixmap->GetDmaBufPitch(plane));
+      attrs.push_back(EGL_LINUX_DRM_PLANE0_MODIFIER0_EXT + plane * 3);
+      attrs.push_back(modifier & 0xffffffff);
+      attrs.push_back(EGL_LINUX_DRM_PLANE0_MODIFIER1_EXT + plane * 3);
+      attrs.push_back((uint32_t)((modifier >> 32) & 0xffffffff));

[piman, 2016/06/07 01:37:46]

nit: use static_cast<uint32_t> instead of c-style cast.

     }
     attrs.push_back(EGL_NONE);
 
     if (!GLImageEGL::Initialize(EGL_LINUX_DMA_BUF_EXT,
                                 static_cast<EGLClientBuffer>(nullptr),
                                 &attrs[0])) {
       return false;
     }
   }
 
   pixmap_ = pixmap;
+

[reveman, 2016/06/07 01:33:10]

nit: avoid adding this blankline?

   return true;
 }
 
 unsigned GLImageOzoneNativePixmap::GetInternalFormat() {
   return internalformat_;
 }
 
 void GLImageOzoneNativePixmap::Destroy(bool have_context) {
   GLImageEGL::Destroy(have_context);
 }
@@ skipping 11 matching lines @@
   return GLImageEGL::CopyTexImage(target);
 }
 
 bool GLImageOzoneNativePixmap::ScheduleOverlayPlane(
     gfx::AcceleratedWidget widget,
     int z_order,
     gfx::OverlayTransform transform,
     const gfx::Rect& bounds_rect,
     const gfx::RectF& crop_rect) {
   DCHECK(pixmap_);
+

[reveman, 2016/06/07 01:33:10]

nit: avoid adding this blankline?

   return pixmap_->ScheduleOverlayPlane(widget, z_order, transform, bounds_rect,
                                        crop_rect);
 }
 
 void GLImageOzoneNativePixmap::OnMemoryDump(
     base::trace_event::ProcessMemoryDump* pmd,
     uint64_t process_tracing_id,
     const std::string& dump_name) {
   // TODO(ericrk): Implement GLImage OnMemoryDump. crbug.com/514914
 }
 
 }  // namespace gl