Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4155)

Unified Diff: chrome/browser/content_settings/tab_specific_content_settings_unittest.cc

Issue 2039803002: Unregister Images, Plugins and Mouselock content settings on android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@only_register_platform_used_contentsettingtypes
Patch Set: address review comments, minor change Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/tab_specific_content_settings_unittest.cc
diff --git a/chrome/browser/content_settings/tab_specific_content_settings_unittest.cc b/chrome/browser/content_settings/tab_specific_content_settings_unittest.cc
index b7a71667137db1d84d6daab0db4c582e9d09aa89..ebb6a5e4e3ccefb27999f70f91217ae8ca75ebbe 100644
--- a/chrome/browser/content_settings/tab_specific_content_settings_unittest.cc
+++ b/chrome/browser/content_settings/tab_specific_content_settings_unittest.cc
@@ -51,12 +51,14 @@ TEST_F(TabSpecificContentSettingsTest, BlockedContent) {
net::CookieOptions options;
// Check that after initializing, nothing is blocked.
+#if !defined(OS_ANDROID)
EXPECT_FALSE(
content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_IMAGES));
EXPECT_FALSE(
- content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_JAVASCRIPT));
- EXPECT_FALSE(
content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_PLUGINS));
+#endif
+ EXPECT_FALSE(
+ content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_JAVASCRIPT));
EXPECT_FALSE(
content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_COOKIES));
EXPECT_FALSE(
@@ -75,7 +77,9 @@ TEST_F(TabSpecificContentSettingsTest, BlockedContent) {
"A=B",
options,
false);
+#if !defined(OS_ANDROID)
content_settings->OnContentBlocked(CONTENT_SETTINGS_TYPE_IMAGES);
+#endif
content_settings->SetPopupsBlocked(true);
TabSpecificContentSettings::MicrophoneCameraState
blocked_microphone_camera_state =
@@ -91,11 +95,13 @@ TEST_F(TabSpecificContentSettingsTest, BlockedContent) {
std::string());
// Check that only the respective content types are affected.
+#if !defined(OS_ANDROID)
EXPECT_TRUE(content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_IMAGES));
EXPECT_FALSE(
- content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_JAVASCRIPT));
- EXPECT_FALSE(
content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_PLUGINS));
+#endif
+ EXPECT_FALSE(
+ content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_JAVASCRIPT));
EXPECT_FALSE(
content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_COOKIES));
EXPECT_TRUE(content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_POPUPS));
@@ -122,12 +128,14 @@ TEST_F(TabSpecificContentSettingsTest, BlockedContent) {
// Reset blocked content settings.
content_settings->ClearBlockedContentSettingsExceptForCookies();
+#if !defined(OS_ANDROID)
EXPECT_FALSE(
content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_IMAGES));
EXPECT_FALSE(
- content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_JAVASCRIPT));
- EXPECT_FALSE(
content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_PLUGINS));
+#endif
+ EXPECT_FALSE(
+ content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_JAVASCRIPT));
EXPECT_TRUE(
content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_COOKIES));
EXPECT_FALSE(
@@ -140,12 +148,14 @@ TEST_F(TabSpecificContentSettingsTest, BlockedContent) {
content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_KEYGEN));
content_settings->ClearCookieSpecificContentSettings();
+#if !defined(OS_ANDROID)
EXPECT_FALSE(
content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_IMAGES));
EXPECT_FALSE(
- content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_JAVASCRIPT));
- EXPECT_FALSE(
content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_PLUGINS));
+#endif
+ EXPECT_FALSE(
+ content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_JAVASCRIPT));
EXPECT_FALSE(
content_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_COOKIES));
EXPECT_FALSE(
« no previous file with comments | « chrome/browser/content_settings/mock_settings_observer.cc ('k') | chrome/browser/ui/website_settings/website_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698