Don't resume paused media. Don't resume playing media after timeout.

media/blink/webmediaplayer_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/webmediaplayer_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <limits>
 #include <string>
@@ skipping 1094 matching lines @@
 
   opaque_ = opaque;
   // Modify content opaqueness of cc::Layer directly so that
   // SetContentsOpaqueIsFixed is ignored.
   if (video_weblayer_)
     video_weblayer_->layer()->SetContentsOpaque(opaque_);
 }
 
 void WebMediaPlayerImpl::OnHidden() {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
+
+  // Don't allow paused players to resume when shown. It's important to check
+  // this here since |delegate_state_| is generally cleared during suspend.

[sandersd (OOO until July 31), 2016/06/07 01:41:16]

It's worth noting here that PAUSED_BUT_NOT_IDLE is purposefully excluded.

+  if (delegate_state_ == DelegateState::PAUSED)
+    is_idle_ = true;
+
+  last_hidden_time_ = base::TimeTicks::Now();
   UpdatePlayState();
 }
 
 void WebMediaPlayerImpl::OnShown() {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
   must_suspend_ = false;
+
+  // Don't auto-resume playback on players that have been idle for some time.
+  // We don't do this when seeking since Blink is waiting for the seeked event
+  // and will get into a bad state if we try and suspend.

[sandersd (OOO until July 31), 2016/06/07 01:41:16]

"try to suspend."

+  if (!paused_ && !seeking_ && !last_hidden_time_.is_null() &&

[sandersd (OOO until July 31), 2016/06/07 01:41:16]

If this is intended to match DelegateState::PAUSED, there are a few more
conditions that UpdatePlayState() checks:

  - !IsNetworkStateError(network_state_)
    We probably shouldn't change the player state when there is an error.

  - !isRemote()
    Same for casting.

  - highest_ready_state_ >= WebMediaPlayer::ReadyStateHaveFutureData
    We want to resume if this isn't true yet.

  - !must_suspend_
    Presumably we don't get OnShown() while the tab is still closed?

  - ready_state_ >= WebMediaPlayer::ReadyStateHaveMetadata
    (Just a clarifies the hasVideo() check, not actually required.)

  - hasVideo()
    We don't want to be pausing audio that is playing.

  - !seeking()
    This is the same as |seeking_| as long as the |ready_state_| check passes.

+      base::TimeTicks::Now() - last_hidden_time_ >
+          base::TimeDelta::FromSeconds(5)) {
+    OnPause();

[sandersd (OOO until July 31), 2016/06/07 01:41:16]

Since OnPause() calls UpdatePlayState(), it's probably better to set |is_idle_|
first.

+    is_idle_ = true;
+  }
+
+  last_hidden_time_ = base::TimeTicks();
   UpdatePlayState();
 }
 
 void WebMediaPlayerImpl::OnSuspendRequested(bool must_suspend) {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
 
   if (must_suspend) {
     must_suspend_ = true;
   } else {
     // TODO(sandersd): Remove this when idleness is separate from play state.
@@ skipping 482 matching lines @@
            << ", Video: " << stats.video_memory_usage << ", DataSource: "
            << (data_source_ ? data_source_->GetMemoryUsage() : 0)
            << ", Demuxer: " << demuxer_memory_usage;
 
   const int64_t delta = current_memory_usage - last_reported_memory_usage_;
   last_reported_memory_usage_ = current_memory_usage;
   adjust_allocated_memory_cb_.Run(delta);
 }
 
 }  // namespace media