Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2039793002: Add documentation of SafePointBarrier internal state. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add documentation of SafePointBarrier internal state. Renamed |m_canResume| to |m_parkingRequested| while doing so, its (inverted) meaning seems clearer imho in this context. R= BUG= Committed: https://crrev.com/452ef01daf240f68f1f0204481721f5cb6f404a0 Cr-Commit-Position: refs/heads/master@{#397988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M third_party/WebKit/Source/platform/heap/SafePoint.h View 1 chunk +26 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/SafePoint.cpp View 6 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
4 years, 6 months ago (2016-06-06 05:29:51 UTC) #3
haraken
LGTM
4 years, 6 months ago (2016-06-06 05:33:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039793002/1
4 years, 6 months ago (2016-06-06 06:38:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 07:13:57 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 07:15:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/452ef01daf240f68f1f0204481721f5cb6f404a0
Cr-Commit-Position: refs/heads/master@{#397988}

Powered by Google App Engine
This is Rietveld 408576698