device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc - Issue 2039773005: Add support in Chrome to send notifications to a specific device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc

Issue 2039773005: Add support in Chrome to send notifications to a specific device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/bluetooth_local_gatt_characteristic_unittest.cc ('K') | « device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.h ('k') | device/bluetooth/test/bluetooth_test.h » ('j') | device/bluetooth/test/bluetooth_test.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc

diff --git a/device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc b/device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc

index cbc240dc5aa0517c8548fdb05e59508fa46530d3..69dbe051bcb08c2545b8969697b33b247791e429 100644

--- a/device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc

+++ b/device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc

@@ -106,10 +106,12 @@ FakeBluetoothGattCharacteristicServiceProvider::

}

void FakeBluetoothGattCharacteristicServiceProvider::SendValueChanged(

- const std::vector<uint8_t>& value) {

+ const dbus::ObjectPath& device_path,

+ const std::vector<uint8_t>& value,

+ bool indicate) {

VLOG(1) << "Sent characteristic value changed: " << object_path_.value()

<< " UUID: " << uuid_;

- sent_value_ = value;

+ sent_value_ = std::make_tuple(device_path.value(), value, indicate);

}

void FakeBluetoothGattCharacteristicServiceProvider::GetValue(