content/browser/service_worker/service_worker_registration.cc - Issue 2039743003: Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration.cc

Issue 2039743003: Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated falken's comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/embedded_worker_instance.cc ('K') | « content/browser/service_worker/service_worker_register_job.cc ('k') | content/browser/service_worker/service_worker_url_request_job.h » ('j') | content/browser/service_worker/service_worker_url_request_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration.cc

diff --git a/content/browser/service_worker/service_worker_registration.cc b/content/browser/service_worker/service_worker_registration.cc

index f822b4c16694595e679e04a762d7ba24de7a6c15..d7fb0b1028c29c10de814da03e1336dfe120bc56 100644

--- a/content/browser/service_worker/service_worker_registration.cc

+++ b/content/browser/service_worker/service_worker_registration.cc

@@ -6,6 +6,7 @@

#include <vector>

+#include "content/browser/service_worker/embedded_worker_status.h"

#include "content/browser/service_worker/service_worker_context_core.h"

#include "content/browser/service_worker/service_worker_context_wrapper.h"

#include "content/browser/service_worker/service_worker_info.h"

@@ -380,7 +381,7 @@ void ServiceWorkerRegistration::DispatchActivateEvent(

}

DCHECK_EQ(ServiceWorkerVersion::ACTIVATING, activating_version->status());

- DCHECK_EQ(ServiceWorkerVersion::RUNNING, activating_version->running_status())

+ DCHECK_EQ(EmbeddedWorkerStatus::RUNNING, activating_version->running_status())

<< "Worker stopped too soon after it was started.";

int request_id = activating_version->StartRequest(

ServiceWorkerMetrics::EventType::ACTIVATE,