content/browser/devtools/protocol/service_worker_handler.cc - Issue 2039743003: Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/service_worker_handler.cc

Issue 2039743003: Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated falken's comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_manager.cc ('k') | content/browser/service_worker/embedded_worker_instance.h » ('j') | content/browser/service_worker/embedded_worker_instance.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/service_worker_handler.cc

diff --git a/content/browser/devtools/protocol/service_worker_handler.cc b/content/browser/devtools/protocol/service_worker_handler.cc

index e008b685875e55800eb00e814119f6635e1d6cd0..2976effb4090ada77308d0550ed2126421e4a25e 100644

--- a/content/browser/devtools/protocol/service_worker_handler.cc

+++ b/content/browser/devtools/protocol/service_worker_handler.cc

@@ -15,6 +15,7 @@

#include "content/browser/frame_host/frame_tree.h"

#include "content/browser/frame_host/frame_tree_node.h"

#include "content/browser/frame_host/render_frame_host_impl.h"

+#include "content/browser/service_worker/embedded_worker_status.h"

#include "content/browser/service_worker/service_worker_context_watcher.h"

#include "content/browser/service_worker/service_worker_context_wrapper.h"

#include "content/browser/service_worker/service_worker_version.h"

@@ -62,15 +63,15 @@ void PushDeliveryNoOp(PushDeliveryStatus status) {

}

const std::string GetVersionRunningStatusString(

- content::ServiceWorkerVersion::RunningStatus running_status) {

+ EmbeddedWorkerStatus running_status) {

switch (running_status) {

- case content::ServiceWorkerVersion::STOPPED:

+ case EmbeddedWorkerStatus::STOPPED:

return kServiceWorkerVersionRunningStatusStopped;

- case content::ServiceWorkerVersion::STARTING:

+ case EmbeddedWorkerStatus::STARTING:

return kServiceWorkerVersionRunningStatusStarting;

- case content::ServiceWorkerVersion::RUNNING:

+ case EmbeddedWorkerStatus::RUNNING:

return kServiceWorkerVersionRunningStatusRunning;

- case content::ServiceWorkerVersion::STOPPING:

+ case EmbeddedWorkerStatus::STOPPING:

return kServiceWorkerVersionRunningStatusStopping;

}

return std::string();