content/browser/service_worker/service_worker_context_core.cc - Issue 2039743003: Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 2039743003: Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move GetWorkerPreparationSuffix Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/embedded_worker_instance.h ('K') | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/browser/service_worker/service_worker_context_watcher.cc » ('j') | content/browser/service_worker/service_worker_url_request_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_core.cc

diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc

index 704f821d151d6b7c874d6452728743f0b82973a6..492be9ceed4aa9002a50c9e3e1b520baedd6a5c9 100644

--- a/content/browser/service_worker/service_worker_context_core.cc

+++ b/content/browser/service_worker/service_worker_context_core.cc

@@ -115,8 +115,10 @@ class ClearAllServiceWorkersHelper

context->GetLiveVersions();

for (const auto& version_itr : live_versions_copy) {

ServiceWorkerVersion* version(version_itr.second);

- if (version->running_status() == ServiceWorkerVersion::STARTING ||

- version->running_status() == ServiceWorkerVersion::RUNNING) {

+ if (version->running_status() ==

+ ServiceWorkerVersion::RunningStatus::STARTING ||

+ version->running_status() ==

+ ServiceWorkerVersion::RunningStatus::RUNNING) {

falken 2016/06/07 03:46:12 Should we use EmbeddedWorkerStatus:: for these use

version->StopWorker(

base::Bind(&ClearAllServiceWorkersHelper::OnResult, this));

}