content/browser/service_worker/service_worker_provider_host.cc - Issue 2039743003: Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 2039743003: Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated the comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_metrics.cc ('k') | content/browser/service_worker/service_worker_register_job.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_provider_host.cc

diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc

index 97caabdf1de84e1df7720c87f84724d494123e93..c31ff54d69d4e317b76f081c605359e89d9e6335 100644

--- a/content/browser/service_worker/service_worker_provider_host.cc

+++ b/content/browser/service_worker/service_worker_provider_host.cc

@@ -10,6 +10,7 @@

#include "base/stl_util.h"

#include "base/time/time.h"

#include "content/browser/message_port_message_filter.h"

+#include "content/browser/service_worker/embedded_worker_status.h"

#include "content/browser/service_worker/service_worker_context_core.h"

#include "content/browser/service_worker/service_worker_context_request_handler.h"

#include "content/browser/service_worker/service_worker_controllee_request_handler.h"

@@ -213,7 +214,7 @@ bool ServiceWorkerProviderHost::SetHostedVersion(

if (active_version())

return false; // Unexpected bad message.

- DCHECK_EQ(ServiceWorkerVersion::STARTING, version->running_status());

+ DCHECK_EQ(EmbeddedWorkerStatus::STARTING, version->running_status());

if (version->embedded_worker()->process_id() != render_process_id_) {

// If we aren't trying to start this version in our process

// something is amiss.