content/browser/service_worker/service_worker_dispatcher_host.cc - Issue 2039743003: Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 2039743003: Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated the comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_watcher.cc ('k') | content/browser/service_worker/service_worker_dispatcher_host_unittest.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc

index de52af6b8ceccaaded76ea5ce0a97abf706b8901..034e0febdbc1749749c7e482a1a177c574161ce4 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc

@@ -17,6 +17,7 @@

#include "content/browser/message_port_message_filter.h"

#include "content/browser/message_port_service.h"

#include "content/browser/service_worker/embedded_worker_registry.h"

+#include "content/browser/service_worker/embedded_worker_status.h"

#include "content/browser/service_worker/service_worker_client_utils.h"

#include "content/browser/service_worker/service_worker_context_core.h"

#include "content/browser/service_worker/service_worker_context_wrapper.h"

@@ -838,7 +839,7 @@ void ServiceWorkerDispatcherHost::OnSetHostedVersionId(int provider_id,

// We might not be STARTING if the stop sequence was entered (STOPPING) or

// ended up being detached (STOPPED).

ServiceWorkerVersion* version = GetContext()->GetLiveVersion(version_id);

- if (!version || version->running_status() != ServiceWorkerVersion::STARTING)

+ if (!version || version->running_status() != EmbeddedWorkerStatus::STARTING)

return;

if (!provider_host->SetHostedVersion(version)) {