Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2039743003: Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « content/content_browser.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 28d90ca0cba04971f8185933e98c46b9baf60fd6..3d964d4485a01fb9d74b73ee72181f9d87369e8d 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -49554,6 +49554,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time"
+ units="ms">
+ <owner>horo@chromium.org</owner>
+ <summary>
+ The time taken to find a Service Worker registration and wait for a worker
+ started to send a FetchEvent request for a main frame resource. The
Mark P 2016/06/07 17:44:09 (1) I'm having trouble parsing this (first) senten
horo 2016/06/08 04:13:23 Done. Revised the summary.
+ measurement starts when the browser process recieves the request and ends
+ when it finds a running worker or it successfully starts a worker. The
+ metric is not recorded in the following situations: 1) The worker was not
+ activated yet. This is intended to avoid including the time for the
+ activation. 2) The worker was started for the fetch AND DevTools was
+ attached during startup. This is intended to avoid including the time for
+ debugging. 3) The request is for New Tab Page.
+ </summary>
+</histogram>
+
<histogram name="ServiceWorker.ActivateEvent.Time" units="ms">
<owner>shimazu@chromium.org</owner>
<summary>
@@ -97058,6 +97074,22 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="ServiceWorker.StartWorker.Time"/>
</histogram_suffixes>
+<histogram_suffixes name="ServiceWorker.WorkerPreparationMode">
+ <suffix name="StartWorkerDuringStartup"
+ label="Started a worker during browser startup."/>
Mark P 2016/06/07 17:44:09 I find these labels confusing, mainly because I th
horo 2016/06/08 04:13:23 An "ACTIVE" Service Worker is different from a sta
+ <suffix name="StartWorkerNewProcess"
+ label="Started a worker in a new process."/>
+ <suffix name="StartWorkerExistingProcess"
+ label="Started a worker in an existing process."/>
+ <suffix name="StartingWorker"
+ label="The activated worker was already starting up."/>
+ <suffix name="RunningWorker"
+ label="The activated worker was already running."/>
+ <suffix name="StoppingWorker" label="The activated worker was stopping."/>
+ <affected-histogram
+ name="ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time"/>
+</histogram_suffixes>
+
<histogram_suffixes name="ServiceWorkerCache.Cache" separator=".">
<suffix name="Batch"
label="The time to perform the 'batch' operation on a ServiceWorker
« no previous file with comments | « content/content_browser.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698