Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 2039743002: X87: [debug] implement intuitive semantics for stepping over await call. (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
Reviewers:
Weiliang, chunyang.dai, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [debug] implement intuitive semantics for stepping over await call. port 8d90210a1e68b141b1b2345b7b898f6920df3a3d (r36718) original commit message: BUG= Committed: https://crrev.com/1763a9e5f3620849edee13957a20cb48169a3bf7 Cr-Commit-Position: refs/heads/master@{#36728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -13 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +35 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-06 02:13:43 UTC) #2
Weiliang
lgtm
4 years, 6 months ago (2016-06-06 02:37:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039743002/1
4 years, 6 months ago (2016-06-06 02:46:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 03:06:27 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 03:09:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1763a9e5f3620849edee13957a20cb48169a3bf7
Cr-Commit-Position: refs/heads/master@{#36728}

Powered by Google App Engine
This is Rietveld 408576698