Issue 203973005: Add an overloaded version of findPlainText() accepting two Positions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203973005: Add an overloaded version of findPlainText() accepting two Positions. (Closed)

Created:
6 years, 9 months ago by Yuta Kitamura

Modified:
6 years, 9 months ago

Reviewers:
yoichio, yosin_UTC9

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add an overloaded version of findPlainText() accepting two Positions. This patch is in continuation of <https://codereview.chromium.org/210363006>;. While the last patch added an overloaded TextIterator constructor, this patch adds similar overloads to findPlainText(), which will be used in the find-in- page implementation in WebFrameImpl. The added function is not used yet. Hence this patch should have no impact on the product behavior. BUG=353430 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170025

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -6 lines)			Patch
	M	Source/core/editing/TextIterator.h	View		3 chunks	+4 lines, -0 lines	0 comments	Download
	M	Source/core/editing/TextIterator.cpp	View		4 chunks	+46 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yutak@chromium.org/203973005/1

6 years, 9 months ago (2014-03-26 06:30:27 UTC) #4

Message was sent while issue was closed.

Change committed as 170025

Expand Messages | Collapse Messages