Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2039723003: tools/android/loading Add timestamps to backend logs. (Closed)

Created:
4 years, 6 months ago by droger
Modified:
4 years, 6 months ago
Reviewers:
mattcary, blundell
CC:
chromium-reviews, mikecase+watch_chromium.org, gabadie+watch_chromium.org, jbudorick+watch_chromium.org, lizeb+watch-android-loading_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/android/loading Add timestamps to backend logs. Committed: https://crrev.com/2afff3487e1ea9ac76233418a029587566253a73 Cr-Commit-Position: refs/heads/master@{#398043}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Convert to UTC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/android/loading/cloud/backend/worker.py View 1 2 chunks +5 lines, -1 line 0 comments Download
M tools/android/loading/cloud/frontend/clovis_frontend.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
droger
4 years, 6 months ago (2016-06-06 14:43:54 UTC) #3
mattcary
lgtm https://codereview.chromium.org/2039723003/diff/20001/tools/android/loading/cloud/backend/worker.py File tools/android/loading/cloud/backend/worker.py (right): https://codereview.chromium.org/2039723003/diff/20001/tools/android/loading/cloud/backend/worker.py#newcode209 tools/android/loading/cloud/backend/worker.py:209: format='[%(asctime)s][%(levelname)s] %(message)s', Do you know if this ends ...
4 years, 6 months ago (2016-06-06 14:50:23 UTC) #4
droger
https://codereview.chromium.org/2039723003/diff/20001/tools/android/loading/cloud/backend/worker.py File tools/android/loading/cloud/backend/worker.py (right): https://codereview.chromium.org/2039723003/diff/20001/tools/android/loading/cloud/backend/worker.py#newcode209 tools/android/loading/cloud/backend/worker.py:209: format='[%(asctime)s][%(levelname)s] %(message)s', On 2016/06/06 14:50:23, mattcary wrote: > Do ...
4 years, 6 months ago (2016-06-06 15:25:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039723003/40001
4 years, 6 months ago (2016-06-06 15:36:42 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-06 16:14:23 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 16:16:25 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2afff3487e1ea9ac76233418a029587566253a73
Cr-Commit-Position: refs/heads/master@{#398043}

Powered by Google App Engine
This is Rietveld 408576698