Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2039723002: Add missing curlies in CocoaDragDropDataProvider (Closed)

Created:
4 years, 6 months ago by tapted
Modified:
4 years, 6 months ago
Reviewers:
spqchan
CC:
chromium-reviews, tfarina, dcheng, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing curlies in CocoaDragDropDataProvider Otherwise the |data_| member is actually static (and causes a static initializer). BUG=599585 TBR=spqchan@chromium.org Committed: https://crrev.com/851eb42016eeca7ac932921164bb1fdb3a5844b3 Cr-Commit-Position: refs/heads/master@{#397956}

Patch Set 1 #

Patch Set 2 : indenty #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/views/cocoa/drag_drop_client_mac.mm View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tapted
4 years, 6 months ago (2016-06-05 23:51:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039723002/20001
4 years, 6 months ago (2016-06-05 23:51:42 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 00:50:14 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 00:51:49 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/851eb42016eeca7ac932921164bb1fdb3a5844b3
Cr-Commit-Position: refs/heads/master@{#397956}

Powered by Google App Engine
This is Rietveld 408576698