[mojo-edk] Make the Mojo EDK compile under NaCl.

[mojo-edk] Make the Mojo EDK compile under NaCl.

BUG=604282
Committed: https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b
Cr-Commit-Position: refs/heads/master@{#397980}

[Anand Mistry (off Chromium), 2016-06-06 01:39:56]

amistry@chromium.org changed reviewers:
+ rockot@chromium.org

[Anand Mistry (off Chromium), 2016-06-06 01:39:57]

Tested by including Mojo in the ppapi-proxy and calling mojo::edk::Init() on
proxy startup (local change, not included in this CL). Verified this compiles
and links, but no effort has been made to verify it run :P

[Ken Rockot(use gerrit already), 2016-06-06 02:58:34]

lgtm

https://codereview.chromium.org/2039713004/diff/20001/mojo/edk/embedder/platf...
File mojo/edk/embedder/platform_channel_pair_posix.cc (right):

https://codereview.chromium.org/2039713004/diff/20001/mojo/edk/embedder/platf...
mojo/edk/embedder/platform_channel_pair_posix.cc:10: #if !defined(OS_NACL) ||
defined(OS_NACL_NONSFI)
nit: The style guide doesn't make a clear statement about this AFAICT but it
seems uncommon to have conditional includes packed in with the rest, even for
system headers. Can this block move down below with other conditional includes?
Same question for all the other conditional includes in this CL.

https://codereview.chromium.org/2039713004/diff/20001/mojo/edk/system/core.cc
File mojo/edk/system/core.cc (right):

https://codereview.chromium.org/2039713004/diff/20001/mojo/edk/system/core.cc...
mojo/edk/system/core.cc:319: return ScopedMessagePipeHandle();
NOTREACHED perhaps?

https://codereview.chromium.org/2039713004/diff/20001/mojo/edk/system/node_ch...
File mojo/edk/system/node_channel.cc (right):

https://codereview.chromium.org/2039713004/diff/20001/mojo/edk/system/node_ch...
mojo/edk/system/node_channel.cc:151: LOG(FATAL) << "Nulti-process not yet
supported on NaCl";
s/Nulti/Multi/

[Anand Mistry (off Chromium), 2016-06-06 03:47:03]

https://codereview.chromium.org/2039713004/diff/20001/mojo/edk/embedder/platf...
File mojo/edk/embedder/platform_channel_pair_posix.cc (right):

https://codereview.chromium.org/2039713004/diff/20001/mojo/edk/embedder/platf...
mojo/edk/embedder/platform_channel_pair_posix.cc:10: #if !defined(OS_NACL) ||
defined(OS_NACL_NONSFI)
On 2016/06/06 02:58:33, Ken Rockot wrote:
> nit: The style guide doesn't make a clear statement about this AFAICT but it
> seems uncommon to have conditional includes packed in with the rest, even for
> system headers. Can this block move down below with other conditional
includes?
> Same question for all the other conditional includes in this CL.

Done.

https://codereview.chromium.org/2039713004/diff/20001/mojo/edk/system/core.cc
File mojo/edk/system/core.cc (right):

https://codereview.chromium.org/2039713004/diff/20001/mojo/edk/system/core.cc...
mojo/edk/system/core.cc:319: return ScopedMessagePipeHandle();
On 2016/06/06 02:58:34, Ken Rockot wrote:
> NOTREACHED perhaps?

Done. I think the return is still necessary though.

https://codereview.chromium.org/2039713004/diff/20001/mojo/edk/system/node_ch...
File mojo/edk/system/node_channel.cc (right):

https://codereview.chromium.org/2039713004/diff/20001/mojo/edk/system/node_ch...
mojo/edk/system/node_channel.cc:151: LOG(FATAL) << "Nulti-process not yet
supported on NaCl";
On 2016/06/06 02:58:34, Ken Rockot wrote:
> s/Nulti/Multi/

Done.

[Anand Mistry (off Chromium), 2016-06-06 05:26:06]

The CQ bit was checked by amistry@chromium.org

[Anand Mistry (off Chromium), 2016-06-06 05:26:06]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2039713004/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2016-06-06 05:26:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039713004/40001

[commit-bot: I haz the power, 2016-06-06 05:42:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-06 05:43:45]

Description was changed from

==========
[mojo-edk] Make the Mojo EDK compile under NaCl.

BUG=604282
==========

to

==========
[mojo-edk] Make the Mojo EDK compile under NaCl.

BUG=604282

Committed: https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b
Cr-Commit-Position: refs/heads/master@{#397980}
==========

[commit-bot: I haz the power, 2016-06-06 05:43:47]

Patchset 3 (id:??) landed as
https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b
Cr-Commit-Position: refs/heads/master@{#397980}