Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: third_party/WebKit/Source/modules/filesystem/LocalFileSystem.h

Issue 2039713002: Remove pre-Oilpan protections from LocalFileSystem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: style Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/filesystem/LocalFileSystem.h
diff --git a/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.h b/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.h
index 1b7b30b825f95c662e30bb4a9d5e96847c0255be..696d955adc353b18c568e8750098236aa4a94c93 100644
--- a/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.h
+++ b/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.h
@@ -33,6 +33,8 @@
#include "core/workers/WorkerClients.h"
#include "platform/FileSystemType.h"
+#include "platform/Supplementable.h"
+#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
#include "wtf/Functional.h"
#include "wtf/PassOwnPtr.h"
@@ -52,13 +54,13 @@ class LocalFileSystem final : public GarbageCollectedFinalized<LocalFileSystem>,
WTF_MAKE_NONCOPYABLE(LocalFileSystem);
public:
static LocalFileSystem* create(PassOwnPtr<FileSystemClient>);
- virtual ~LocalFileSystem();
+ ~LocalFileSystem();
void resolveURL(ExecutionContext*, const KURL&, PassOwnPtr<AsyncFileSystemCallbacks>);
void requestFileSystem(ExecutionContext*, FileSystemType, long long size, PassOwnPtr<AsyncFileSystemCallbacks>);
void deleteFileSystem(ExecutionContext*, FileSystemType, PassOwnPtr<AsyncFileSystemCallbacks>);
- FileSystemClient* client() { return m_client.get(); }
+ FileSystemClient* client() const { return m_client.get(); }
static const char* supplementName();
static LocalFileSystem* from(ExecutionContext&);
@@ -69,17 +71,18 @@ public:
Supplement<WorkerClients>::trace(visitor);
}
-protected:
+private:
explicit LocalFileSystem(PassOwnPtr<FileSystemClient>);
-private:
- WebFileSystem* fileSystem() const;
- void requestFileSystemAccessInternal(ExecutionContext*, std::unique_ptr<SameThreadClosure> allowed, std::unique_ptr<SameThreadClosure> denied);
+ WebFileSystem* getFileSystem() const;
void fileSystemNotAvailable(ExecutionContext*, CallbackWrapper*);
+
+ void requestFileSystemAccessInternal(ExecutionContext*, std::unique_ptr<SameThreadClosure> allowed, std::unique_ptr<SameThreadClosure> denied);
void fileSystemNotAllowedInternal(ExecutionContext*, CallbackWrapper*);
void fileSystemAllowedInternal(ExecutionContext*, FileSystemType, CallbackWrapper*);
void resolveURLInternal(ExecutionContext*, const KURL&, CallbackWrapper*);
void deleteFileSystemInternal(ExecutionContext*, FileSystemType, CallbackWrapper*);
+
OwnPtr<FileSystemClient> m_client;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698