Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 20397002: Fix build with system V8. (Closed)

Created:
7 years, 4 months ago by Paweł Hajdan Jr.
Modified:
7 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Fix build with system V8. This updates gypi includes to match updated upstream v8.gyp. common.gypi has been split and no longer exists. BUG=none R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213731

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/linux/unbundle/v8.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
7 years, 4 months ago (2013-07-25 18:19:12 UTC) #1
Lei Zhang
lgtm
7 years, 4 months ago (2013-07-25 23:16:45 UTC) #2
Paweł Hajdan Jr.
7 years, 4 months ago (2013-07-26 00:38:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r213731 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698