Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 203963010: Add test cases for small radii to rrect GMs (Closed)

Created:
6 years, 9 months ago by bsalomon
Modified:
6 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add test cases for small radii to rrect GMs. BUG=skia:2181 Committed: http://code.google.com/p/skia/source/detail?r=13905

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : comment change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M gm/rrects.cpp View 1 2 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
6 years, 9 months ago (2014-03-24 14:05:17 UTC) #1
robertphillips
lgtm - don't we need an accompanying ignore file change though?
6 years, 9 months ago (2014-03-24 14:06:54 UTC) #2
bsalomon
On 2014/03/24 14:06:54, robertphillips wrote: > lgtm - don't we need an accompanying ignore file ...
6 years, 9 months ago (2014-03-24 14:16:21 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-24 14:16:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/203963010/40001
6 years, 9 months ago (2014-03-24 14:16:34 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 14:53:10 UTC) #6
Message was sent while issue was closed. 
Change committed as 13905

Powered by Google App Engine
This is Rietveld 408576698