Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html

Issue 203963008: [CSS Grid Layout] Vertical rectangles not recognized as valid grid areas (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html
diff --git a/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html b/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html
index 58017e24766cd806982de38a94fbd90131091160..64c702e7f14c44766a5bbbcff33391a43a9c1c3f 100644
--- a/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html
+++ b/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html
@@ -29,6 +29,18 @@
grid-template-areas: "header ."
"footer .";
}
+
+#gridWithHorizontalRectangle {
+ grid-template-areas: "a a a"
+ "a a a";
+}
+
+#gridWithVerticalRectangle {
+ grid-template-areas: "a a"
+ "a a"
+ "a a";
+}
+
</style>
<script src="../../resources/js-test.js"></script>
</head>
@@ -40,6 +52,8 @@
<div class="grid" id="gridWithSpanningColumnsTemplate"></div>
<div class="grid" id="gridWithSpanningRowsDotTemplate"></div>
<div class="grid" id="gridWithDotColumn"></div>
+<div class="grid" id="gridWithHorizontalRectangle"></div>
+<div class="grid" id="gridWithVerticalRectangle"></div>
<script>
description("This test checks that grid-template-areas is properly parsed.");
@@ -65,6 +79,12 @@
var gridWithDotColumn = document.getElementById("gridWithDotColumn");
shouldBeEqualToString("window.getComputedStyle(gridWithDotColumn).getPropertyValue('grid-template-areas')", '"header ." "footer ."')
+ var gridWithHorizontalRectangle = document.getElementById("gridWithHorizontalRectangle");
+ shouldBeEqualToString("window.getComputedStyle(gridWithHorizontalRectangle).getPropertyValue('grid-template-areas')", '"a a a" "a a a"');
+
+ var gridWithVerticalRectangle = document.getElementById("gridWithVerticalRectangle");
+ shouldBeEqualToString("window.getComputedStyle(gridWithVerticalRectangle).getPropertyValue('grid-template-areas')", '"a a" "a a" "a a"');
+
debug("Test grid-template-areas: initial");
var element = document.createElement("div");
document.body.appendChild(element);
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698