Issue 203963008: [CSS Grid Layout] Vertical rectangles not recognized as valid grid areas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203963008: [CSS Grid Layout] Vertical rectangles not recognized as valid grid areas (Closed)

Created:
6 years, 9 months ago by svillar

Modified:
6 years, 9 months ago

Reviewers:
leviw_travelin_and_unemployed, eseidel, esprehn, Julien - ping for review

CC:
blink-reviews, jfernandez, svillar, Manuel Rego, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis, rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[CSS Grid Layout] Vertical rectangles not recognized as valid grid areas Grid areas sized as vertical rectangles were incorrectly considered as invalid by the parser. That's because the condition checking that each new row was adjacent to the previous one was using the first row of the currently parsed grid area instead of the last one. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169699

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -1 line)			Patch
M	LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html	View	3 chunks	+20 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Julien - ping for review

The CQ bit was checked by jchaffraix@chromium.org

6 years, 9 months ago (2014-03-20 21:00:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svillar@igalia.com/203963008/1

6 years, 9 months ago (2014-03-20 21:00:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svillar@igalia.com/203963008/1

6 years, 9 months ago (2014-03-20 21:56:30 UTC) #5

Message was sent while issue was closed.

Change committed as 169699

Expand Messages | Collapse Messages