Added STACK_ALLOCATED annotations according to the Blink GC plugin requirements.

Added STACK_ALLOCATED annotations according to the Blink GC plugin requirements.

R=ager@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169690

[zerny-chromium, 2014-03-20 09:58:56]

Plugin side change: https://codereview.chromium.org/206123004/

I'm not sure we want to require all classes to be STACK_ALLOCATED. Please
discuss the requirement in the Plugin side CL.

[zerny-chromium, 2014-03-20 15:14:46]

The plugin now allows derived classes to inherit the STACK_ALLOCATED property.
PTAL

[haraken, 2014-03-20 15:19:17]

The diff of the latest patch set looks fair! LGTM.

https://codereview.chromium.org/203963005/diff/40001/Source/core/css/parser/C...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/203963005/diff/40001/Source/core/css/parser/C...
Source/core/css/parser/CSSPropertyParser.cpp:5574:
RefPtrWillBeRawPtr<CSSPrimitiveValue> color;

After landing this CL, I'll sweep the code base and replace RawPtrs in
stack-allocated objects with Members.

[zerny-chromium, 2014-03-20 15:21:05]

https://codereview.chromium.org/203963005/diff/40001/Source/core/css/parser/C...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/203963005/diff/40001/Source/core/css/parser/C...
Source/core/css/parser/CSSPropertyParser.cpp:5574:
RefPtrWillBeRawPtr<CSSPrimitiveValue> color;
On 2014/03/20 15:19:18, haraken wrote:
> 
> After landing this CL, I'll sweep the code base and replace RawPtrs in
> stack-allocated objects with Members.

I'm going to add a that as a hard requirement to the plugin in a follow-up CL so
I would be happy to make that change Blink side.

[haraken, 2014-03-20 15:22:36]

https://codereview.chromium.org/203963005/diff/40001/Source/core/css/parser/C...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/203963005/diff/40001/Source/core/css/parser/C...
Source/core/css/parser/CSSPropertyParser.cpp:5574:
RefPtrWillBeRawPtr<CSSPrimitiveValue> color;
On 2014/03/20 15:21:06, zerny-chromium wrote:
> On 2014/03/20 15:19:18, haraken wrote:
> > 
> > After landing this CL, I'll sweep the code base and replace RawPtrs in
> > stack-allocated objects with Members.
> 
> I'm going to add a that as a hard requirement to the plugin in a follow-up CL
so
> I would be happy to make that change Blink side.

thanks, then go ahead :)

[Mads Ager (chromium), 2014-03-20 15:23:38]

LGTM

[zerny-chromium, 2014-03-20 15:24:28]

The CQ bit was checked by zerny@chromium.org

[commit-bot: I haz the power, 2014-03-20 15:24:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zerny@chromium.org/203963005/40001

[commit-bot: I haz the power, 2014-03-20 15:24:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 15:24:41]

Failed to apply patch for Source/core/css/parser/MediaQueryParser.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/parser/MediaQueryParser.h
  Hunk #1 FAILED at 18.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/css/parser/MediaQueryParser.h.rej

Patch:       Source/core/css/parser/MediaQueryParser.h
Index: Source/core/css/parser/MediaQueryParser.h
diff --git a/Source/core/css/parser/MediaQueryParser.h
b/Source/core/css/parser/MediaQueryParser.h
index
e31fc332ef85a29537a226830819a93595830642..fcb82c569bd11de88eadcc31a930a69f0a8dad3b
100644
--- a/Source/core/css/parser/MediaQueryParser.h
+++ b/Source/core/css/parser/MediaQueryParser.h
@@ -18,7 +18,7 @@ namespace WebCore {
 class MediaQuerySet;
 
 class MediaQueryData {
-    ALLOW_ONLY_INLINE_ALLOCATION();
+    STACK_ALLOCATED();
 private:
     MediaQuery::Restrictor m_restrictor;
     String m_mediaType;

[zerny-chromium, 2014-03-20 15:36:08]

The CQ bit was checked by zerny@chromium.org

[commit-bot: I haz the power, 2014-03-20 15:36:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zerny@chromium.org/203963005/40002

[commit-bot: I haz the power, 2014-03-20 16:21:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 16:21:54]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[zerny-chromium, 2014-03-20 20:11:21]

The CQ bit was checked by zerny@chromium.org

[commit-bot: I haz the power, 2014-03-20 20:11:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zerny@chromium.org/203963005/40002

[commit-bot: I haz the power, 2014-03-20 20:41:22]

Change committed as 169690