Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3491)

Unified Diff: chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc

Issue 2039593002: [Md Feedback] Add initial content/strings to feedback-container element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per hcarmona@'s comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
diff --git a/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc b/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
index 5afb358f1e221f40a63f9f9cf1cc82114f3e3cbd..f740732c7ad1b1a1e8553cf1c7451f19e59edae2 100644
--- a/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
+++ b/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
@@ -6,6 +6,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/url_constants.h"
+#include "chrome/grit/generated_resources.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_ui_data_source.h"
@@ -69,13 +70,50 @@ class MdFeedbackDialogDelegate : public ui::WebDialogDelegate {
} // namespace
+namespace {
+
+content::WebUIDataSource* CreateMdFeedbackUIHTMLSource(Profile* profile) {
+ content::WebUIDataSource* html_source =
+ content::WebUIDataSource::Create(chrome::kChromeUIFeedbackHost);
+
+ // General strings.
+ html_source->AddLocalizedString("headingText",
+ IDS_MD_FEEDBACK_HEADING);
+
+ // Input labels.
+ html_source->AddLocalizedString("emailLabel",
+ IDS_MD_FEEDBACK_USER_EMAIL_LABEL);
+ html_source->AddLocalizedString("openEndedLabel",
+ IDS_MD_FEEDBACK_OPEN_ENDED_LABEL);
+ html_source->AddLocalizedString("urlLabel",
+ IDS_MD_FEEDBACK_URL_LABEL);
+
+ // Buttons.
+ html_source->AddLocalizedString("cancelButton",
+ IDS_MD_FEEDBACK_CANCEL_BUTTON);
+ html_source->AddLocalizedString("sendReportButton",
+ IDS_MD_FEEDBACK_SEND_REPORT_BUTTON);
+
+ // Polymer resources.
+ html_source->AddResourcePath("feedback_container.html",
+ IDR_MD_FEEDBACK_FEEDBACK_CONTAINER_HTML);
+ html_source->AddResourcePath("feedback_container.js",
+ IDR_MD_FEEDBACK_FEEDBACK_CONTAINER_JS);
+
+ html_source->SetJsonPath("strings.js");
+ html_source->SetDefaultResource(IDR_MD_FEEDBACK_FEEDBACK_HTML);
+ return html_source;
+}
+
+} // namespace
+
MdFeedbackUI::MdFeedbackUI(content::WebUI* web_ui)
: content::WebUIController(web_ui) {
// Set up the chrome://feedback data html_source.
+ Profile* profile = Profile::FromWebUI(web_ui);
content::WebUIDataSource* html_source =
- content::WebUIDataSource::Create(chrome::kChromeUIFeedbackHost);
- html_source->SetDefaultResource(IDR_MD_FEEDBACK_FEEDBACK_HTML);
- content::WebUIDataSource::Add(Profile::FromWebUI(web_ui), html_source);
+ CreateMdFeedbackUIHTMLSource(profile);
+ content::WebUIDataSource::Add(profile, html_source);
}
MdFeedbackUI::~MdFeedbackUI() {}
« no previous file with comments | « chrome/browser/resources/md_feedback/feedback_container.js ('k') | ui/webui/resources/polymer_resources.grdp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698