chrome/browser/resources/md_feedback/feedback_container.html - Issue 2039593002: [Md Feedback] Add initial content/strings to feedback-container element.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_feedback/feedback_container.html

Issue 2039593002: [Md Feedback] Add initial content/strings to feedback-container element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per dbeam@'s comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/md_feedback/feedback_container.css ('k') | chrome/browser/resources/md_feedback/feedback_container.js » ('j') | ui/webui/resources/polymer_resources.grdp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-texta rea.html">

	5 <dom-module name="feedback-container">

	6 <link rel="import" type="css" href="feedback_container.css">
	Dan Beam 2016/06/09 22:50:53 note: this syntax (link type=css) is deprecated. note: this syntax (link type=css) is deprecated. can you just put the <style> inline in the HTML? apacible 2016/06/10 20:09:52 Noted. Show quoted text On 2016/06/09 22:50:53, Dan Beam wrote: > note: this syntax (link type=css) is deprecated. Noted. Show quoted text > can you just put the <style> inline in the HTML? Done.
	7 <template>

	8 <div id="header">

	9 <span>$i18n{headingText}</span>

	10 </div>

	11 <div>

	12 <paper-textarea label="$i18n{openEndedLabel}"></paper-textarea>

	13 <paper-input label="$i18n{urlLabel}"></paper-input>

	14 <paper-input label="$i18n{emailLabel}"></paper-input>

	15 </div>

	16 <div>

	17 <paper-button>

	18 <span>$i18n{cancelButton}</span>
	Dan Beam 2016/06/09 22:50:53 why are you wrapping with a <span>? why are you wrapping with a <span>? apacible 2016/06/10 20:09:52 Removed. Show quoted text On 2016/06/09 22:50:53, Dan Beam wrote: > why are you wrapping with a <span>? Removed.
	19 </paper-button>

	20 <paper-button id="submit-button">

	21 <span>$i18n{sendReportButton}</span>

	22 </paper-button>

	23 </div>

	24 </template>

	25 <script src="feedback_container.js"></script>

	26 </dom-module>

OLD	NEW