Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2039573002: Resynthesize ClassElementImpl fields and property accessors lazily. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resynthesize ClassElementImpl fields and property accessors lazily. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/7af5b1c5310648119970e01b33a91e5bf43fae1d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -133 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 14 chunks +137 lines, -13 lines 1 comment Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 5 chunks +3 lines, -118 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 6 months ago (2016-06-03 19:59:27 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2039573002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2039573002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode1179 pkg/analyzer/lib/src/dart/element/element.dart:1179: // Build explicit fields and implicit property accessors. ...
4 years, 6 months ago (2016-06-03 20:06:48 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 7af5b1c5310648119970e01b33a91e5bf43fae1d (presubmit successful).
4 years, 6 months ago (2016-06-03 20:10:31 UTC) #4
Brian Wilkerson
4 years, 6 months ago (2016-06-03 20:33:50 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698