Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2039523002: 💪 target_cpu -> current_cpu in chrome/android/chrome_public_apk_tmpl.gni (Closed)

Created:
4 years, 6 months ago by agrieve
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@monochrome
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

target_cpu -> current_cpu in chrome/android/chrome_public_apk_tmpl.gni BUG=616819 Committed: https://crrev.com/a35f7d85bc36253ff07033efeddac4d1cb188068 Cr-Commit-Position: refs/heads/master@{#398573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/chrome_public_apk_tmpl.gni View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
agrieve
4 years, 6 months ago (2016-06-03 17:20:43 UTC) #2
David Trainor- moved to gerrit
this lgtm pending the discussion on current_cpu and target_cpu in the relevant bug and the ...
4 years, 6 months ago (2016-06-06 21:20:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039523002/1
4 years, 6 months ago (2016-06-08 14:40:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 15:55:00 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 15:56:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a35f7d85bc36253ff07033efeddac4d1cb188068
Cr-Commit-Position: refs/heads/master@{#398573}

Powered by Google App Engine
This is Rietveld 408576698