Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2039503002: Invalidate only non-scrolling layers for non-scrolling content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 428
429 // FIXME: generalize accessors to backing GraphicsLayers so that this code i s squashing-agnostic. 429 // FIXME: generalize accessors to backing GraphicsLayers so that this code i s squashing-agnostic.
430 if (layer()->groupedMapping()) { 430 if (layer()->groupedMapping()) {
431 LayoutRect paintInvalidationRect = r; 431 LayoutRect paintInvalidationRect = r;
432 if (GraphicsLayer* squashingLayer = layer()->groupedMapping()->squashing Layer()) { 432 if (GraphicsLayer* squashingLayer = layer()->groupedMapping()->squashing Layer()) {
433 // Note: the subpixel accumulation of layer() does not need to be ad ded here. It is already taken into account. 433 // Note: the subpixel accumulation of layer() does not need to be ad ded here. It is already taken into account.
434 squashingLayer->setNeedsDisplayInRect(enclosingIntRect(paintInvalida tionRect), invalidationReason, object); 434 squashingLayer->setNeedsDisplayInRect(enclosingIntRect(paintInvalida tionRect), invalidationReason, object);
435 } 435 }
436 } else if (compositedScrollsWithRespectTo(&object, *this)) { 436 } else if (compositedScrollsWithRespectTo(&object, *this)) {
437 layer()->compositedLayerMapping()->setScrollingContentsNeedDisplayInRect (r, invalidationReason, object); 437 layer()->compositedLayerMapping()->setScrollingContentsNeedDisplayInRect (r, invalidationReason, object);
438 } else if (usesCompositedScrolling()) {
439 layer()->compositedLayerMapping()->setNonScrollingContentsNeedDisplayInR ect(r, invalidationReason, object);
438 } else { 440 } else {
439 // TODO(chrishtr): we should be able to skip scrolling content layers in this case. 441 // Otherwise invalidate everything.
440 layer()->compositedLayerMapping()->setContentsNeedDisplayInRect(r, inval idationReason, object); 442 layer()->compositedLayerMapping()->setContentsNeedDisplayInRect(r, inval idationReason, object);
441 } 443 }
442 } 444 }
443 445
444 void LayoutBoxModelObject::invalidateDisplayItemClientOnBacking(const DisplayIte mClient& displayItemClient, PaintInvalidationReason invalidationReason, const La youtObject* layoutObject) const 446 void LayoutBoxModelObject::invalidateDisplayItemClientOnBacking(const DisplayIte mClient& displayItemClient, PaintInvalidationReason invalidationReason, const La youtObject* layoutObject) const
445 { 447 {
446 displayItemClient.setDisplayItemsUncached(); 448 displayItemClient.setDisplayItemsUncached();
447 449
448 // We need to inform the GraphicsLayer about this paint invalidation only wh en we are tracking 450 // We need to inform the GraphicsLayer about this paint invalidation only wh en we are tracking
449 // paint invalidation or ENABLE(ASSERT). 451 // paint invalidation or ENABLE(ASSERT).
(...skipping 679 matching lines...) Expand 10 before | Expand all | Expand 10 after
1129 if (rootElementStyle->hasBackground()) 1131 if (rootElementStyle->hasBackground())
1130 return false; 1132 return false;
1131 1133
1132 if (node() != document().firstBodyElement()) 1134 if (node() != document().firstBodyElement())
1133 return false; 1135 return false;
1134 1136
1135 return true; 1137 return true;
1136 } 1138 }
1137 1139
1138 } // namespace blink 1140 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698