Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2039493002: Reland of [Autofill] Sort profiles and credit cards by frecency in PaymentRequest. (Closed)

Created:
4 years, 6 months ago by please use gerrit instead
Modified:
4 years, 6 months ago
Reviewers:
Mathieu, johnme, sebsg, gone
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, rouslan+autofill_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [Autofill] Sort profiles and credit cards by frecency in PaymentRequest. (patchset #1 id:1 of https://codereview.chromium.org/2033323003/ ) Reason for revert: Clankium failures should not revert Chromium. The correct course of action is to fix-up the Clankium code, into which Chromium developers have no visibility. Original issue's description: > Revert of [Autofill] Sort profiles and credit cards by frecency in PaymentRequest. (patchset #12 id:620001 of https://codereview.chromium.org/1982623002/ ) > > Reason for revert: > This broke the downstream clang-clankium-tot-builder, since PersonalDataManager at least is used by downstream autofill code to get profiles and credit cards: https://goto.google.com/kneae > > Original issue's description: > > Sorted the profiles and credit cards to be used in PaymentRequest. > > > > Also added test methods to set the use count and use date of profiles and cards. > > > > BUG=609864 > > TEST=PersonalDataManagerTestJava > > > > Committed: https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2 > > Cr-Commit-Position: refs/heads/master@{#397562} > > TBR=mathp@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org,sebsg@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=609864 > > Committed: https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e > Cr-Commit-Position: refs/heads/master@{#397679} TBR=mathp@chromium.org,dfalcantara@chromium.org,sebsg@chromium.org,johnme@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609864 Committed: https://crrev.com/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3 Cr-Commit-Position: refs/heads/master@{#397721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+612 lines, -249 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java View 5 chunks +75 lines, -31 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java View 3 chunks +97 lines, -20 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java View 11 chunks +111 lines, -15 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.h View 3 chunks +72 lines, -21 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.cc View 5 chunks +185 lines, -119 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.h View 4 chunks +10 lines, -2 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 5 chunks +51 lines, -31 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
please use gerrit instead
Created Reland of [Autofill] Sort profiles and credit cards by frecency in PaymentRequest.
4 years, 6 months ago (2016-06-03 16:19:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2039493002/1
4 years, 6 months ago (2016-06-03 16:19:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 16:20:49 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 16:22:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3
Cr-Commit-Position: refs/heads/master@{#397721}

Powered by Google App Engine
This is Rietveld 408576698