Add a libfuzzer for usrsctp, an SCTP userland stack.

Add a libfuzzer for usrsctp, an SCTP userland stack.

Usrsctp is used in WebRTC to handle packets in the data channel.

BUG=

Committed: https://crrev.com/44b0ee841e1ed63be56e3d94e2a654f1706c0c61
Cr-Commit-Position: refs/heads/master@{#398009}

[katrielc, 2016-06-03 16:54:56]

Description was changed from

==========
Add a libfuzzer for usrsctp, an SCTP userland stack.

Usrsctp is used in WebRTC to handle packets in the data channel.

BUG=
==========

to

==========
Add a libfuzzer for usrsctp, an SCTP userland stack.

Usrsctp is used in WebRTC to handle packets in the data channel.

BUG=
==========

[katrielc, 2016-06-03 16:54:56]

katrielc@chromium.org changed reviewers:
+ mmoroz@chromium.org

[katrielc, 2016-06-03 16:55:36]

Hey, I wrote a fuzzer :)

[mmoroz, 2016-06-03 17:53:20]

Left some comments. Thanks for implementing this!

https://codereview.chromium.org/2039483003/diff/1/testing/libfuzzer/fuzzers/u...
File testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc (right):

https://codereview.chromium.org/2039483003/diff/1/testing/libfuzzer/fuzzers/u...
testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc:4: 
Could you please include <stddef.h> and <stdint.h>. We tend to include them
explicitly to be sure that uint8_t and size_t are always defined.

https://codereview.chromium.org/2039483003/diff/1/testing/libfuzzer/fuzzers/u...
testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc:5: #include "usrsctp.h"
Please use the full path, I guess it will be:
#include "third_party/usrsctp/usrsctplib/usrsctplib/usrsctp.h"

https://codereview.chromium.org/2039483003/diff/1/testing/libfuzzer/fuzzers/u...
testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc:13: };
I think it would be better to have an empty line between function definitions.

https://codereview.chromium.org/2039483003/diff/1/testing/libfuzzer/fuzzers/u...
testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc:18: void InitializeUsrsctp() {
I recommend to do environment initialization in this way:
https://cs.chromium.org/chromium/src/testing/libfuzzer/fuzzers/gfx_png_image_...

https://codereview.chromium.org/2039483003/diff/1/testing/libfuzzer/fuzzers/u...
testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc:23: //
usrsctp_sysctl_set_sctp_ecn_enable(0);
Do we need this line commented out? Could you please add a comment with
explanation (e.g. if it is some TODO or FIXME thing, or what does it mean) or
remove it if it doesn't matter.

[katrielc, 2016-06-03 18:25:46]

https://codereview.chromium.org/2039483003/diff/1/testing/libfuzzer/fuzzers/u...
File testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc (right):

https://codereview.chromium.org/2039483003/diff/1/testing/libfuzzer/fuzzers/u...
testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc:4: 
On 2016/06/03 17:53:20, mmoroz wrote:
> Could you please include <stddef.h> and <stdint.h>. We tend to include them
> explicitly to be sure that uint8_t and size_t are always defined.

Done.

https://codereview.chromium.org/2039483003/diff/1/testing/libfuzzer/fuzzers/u...
testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc:5: #include "usrsctp.h"
On 2016/06/03 17:53:20, mmoroz wrote:
> Please use the full path, I guess it will be:
> #include "third_party/usrsctp/usrsctplib/usrsctplib/usrsctp.h"

Done.

https://codereview.chromium.org/2039483003/diff/1/testing/libfuzzer/fuzzers/u...
testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc:13: };
On 2016/06/03 17:53:20, mmoroz wrote:
> I think it would be better to have an empty line between function definitions.

Done.

https://codereview.chromium.org/2039483003/diff/1/testing/libfuzzer/fuzzers/u...
testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc:18: void InitializeUsrsctp() {
On 2016/06/03 17:53:20, mmoroz wrote:
> I recommend to do environment initialization in this way:
>
https://cs.chromium.org/chromium/src/testing/libfuzzer/fuzzers/gfx_png_image_...

Done. Out of curiosity is this a style-guide thing or is there a particular
reason for it?

https://codereview.chromium.org/2039483003/diff/1/testing/libfuzzer/fuzzers/u...
testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc:23: //
usrsctp_sysctl_set_sctp_ecn_enable(0);
On 2016/06/03 17:53:20, mmoroz wrote:
> Do we need this line commented out? Could you please add a comment with
> explanation (e.g. if it is some TODO or FIXME thing, or what does it mean) or
> remove it if it doesn't matter.

Done.

[mmoroz, 2016-06-06 10:42:41]

LGTM with small nits about codestyle. Feel free to land after addressing nits.

https://codereview.chromium.org/2039483003/diff/20001/testing/libfuzzer/fuzze...
File testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc (right):

https://codereview.chromium.org/2039483003/diff/20001/testing/libfuzzer/fuzze...
testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc:7: #include
"third_party/usrsctp/usrsctplib/usrsctplib/usrsctp.h"
Please add one empty line between system headers and this one.

https://codereview.chromium.org/2039483003/diff/20001/testing/libfuzzer/fuzze...
testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc:17: static void ignore2(const char*
format, ...){};
One space before '{}'.

[katrielc, 2016-06-06 11:10:40]

Great, thanks!

https://codereview.chromium.org/2039483003/diff/20001/testing/libfuzzer/fuzze...
File testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc (right):

https://codereview.chromium.org/2039483003/diff/20001/testing/libfuzzer/fuzze...
testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc:7: #include
"third_party/usrsctp/usrsctplib/usrsctplib/usrsctp.h"
On 2016/06/06 10:42:40, mmoroz wrote:
> Please add one empty line between system headers and this one.

Done.

https://codereview.chromium.org/2039483003/diff/20001/testing/libfuzzer/fuzze...
testing/libfuzzer/fuzzers/usrsctp_fuzzer.cc:17: static void ignore2(const char*
format, ...){};
On 2016/06/06 10:42:40, mmoroz wrote:
> One space before '{}'.

Done.

[katrielc, 2016-06-06 11:14:27]

The CQ bit was checked by katrielc@chromium.org

[katrielc, 2016-06-06 11:14:27]

The patchset sent to the CQ was uploaded after l-g-t-m from mmoroz@chromium.org
Link to the patchset: https://codereview.chromium.org/2039483003/#ps40001
(title: "Final codereview changes")

[commit-bot: I haz the power, 2016-06-06 11:14:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039483003/40001

[commit-bot: I haz the power, 2016-06-06 12:25:12]

Description was changed from

==========
Add a libfuzzer for usrsctp, an SCTP userland stack.

Usrsctp is used in WebRTC to handle packets in the data channel.

BUG=
==========

to

==========
Add a libfuzzer for usrsctp, an SCTP userland stack.

Usrsctp is used in WebRTC to handle packets in the data channel.

BUG=
==========

[commit-bot: I haz the power, 2016-06-06 12:25:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-06 12:26:13]

Description was changed from

==========
Add a libfuzzer for usrsctp, an SCTP userland stack.

Usrsctp is used in WebRTC to handle packets in the data channel.

BUG=
==========

to

==========
Add a libfuzzer for usrsctp, an SCTP userland stack.

Usrsctp is used in WebRTC to handle packets in the data channel.

BUG=

Committed: https://crrev.com/44b0ee841e1ed63be56e3d94e2a654f1706c0c61
Cr-Commit-Position: refs/heads/master@{#398009}
==========

[commit-bot: I haz the power, 2016-06-06 12:26:14]

Patchset 3 (id:??) landed as
https://crrev.com/44b0ee841e1ed63be56e3d94e2a654f1706c0c61
Cr-Commit-Position: refs/heads/master@{#398009}