Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2039463004: Revert of Mark some AwContentsClientFullScreenTest tests flaky. (Closed)

Created:
4 years, 6 months ago by boliu
Modified:
4 years, 6 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mark some AwContentsClientFullScreenTest tests flaky. (patchset #2 id:20001 of https://codereview.chromium.org/2011453002/ ) Reason for revert: Avoid disabling these tests on CQ Original issue's description: > Mark some AwContentsClientFullScreenTest tests flaky. > > BUG=614318 > > Committed: https://crrev.com/22a7f8467da532e4ab9f07256de4a11e93888341 > Cr-Commit-Position: refs/heads/master@{#395588} TBR=torne@chromium.org,mvanouwerkerk@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=614318 Committed: https://crrev.com/63d6ee6f55ea3a0752620eb7695ed871deca407c Cr-Commit-Position: refs/heads/master@{#397859}

Patch Set 1 #

Patch Set 2 : manual revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java View 1 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
boliu
Created Revert of Mark some AwContentsClientFullScreenTest tests flaky.
4 years, 6 months ago (2016-06-03 23:00:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039463004/1
4 years, 6 months ago (2016-06-03 23:00:41 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/76545) linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, ...
4 years, 6 months ago (2016-06-03 23:04:50 UTC) #5
boliu
On 2016/06/03 23:04:50, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-06-03 23:05:36 UTC) #6
boliu
manually reverted and uploaded as PS2
4 years, 6 months ago (2016-06-03 23:22:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039463004/40001
4 years, 6 months ago (2016-06-03 23:23:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-04 00:42:30 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 00:45:59 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63d6ee6f55ea3a0752620eb7695ed871deca407c
Cr-Commit-Position: refs/heads/master@{#397859}

Powered by Google App Engine
This is Rietveld 408576698