Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2039453003: Fix crash in blocked input event warning. (Closed)

Created:
4 years, 6 months ago by dgozman
Modified:
4 years, 6 months ago
Reviewers:
caseq, adamk
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in blocked input event warning. If event does not come from JS, we should enter the context scope. BUG=617229 Committed: https://crrev.com/ba936770ca24f657b27361611cc0a0e4939c080b Cr-Commit-Position: refs/heads/master@{#397928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/core/events/EventTarget.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dgozman
Take a look please. I wasn't able to write a test easily - it involves ...
4 years, 6 months ago (2016-06-04 02:08:35 UTC) #2
caseq
lgtm
4 years, 6 months ago (2016-06-04 02:22:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039453003/1
4 years, 6 months ago (2016-06-04 04:57:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/233508)
4 years, 6 months ago (2016-06-04 08:56:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039453003/1
4 years, 6 months ago (2016-06-04 14:12:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-04 15:58:37 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 16:01:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba936770ca24f657b27361611cc0a0e4939c080b
Cr-Commit-Position: refs/heads/master@{#397928}

Powered by Google App Engine
This is Rietveld 408576698