Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2039383002: Add missing locking around loaders list (Closed)

Created:
4 years, 6 months ago by Cutch
Modified:
4 years, 6 months ago
Reviewers:
turnidge, zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing locking around loaders list BUG= Committed: https://github.com/dart-lang/sdk/commit/1020392647d9a6a1a4b71db1c15795fcb7857959

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M runtime/bin/loader.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/loader.cc View 4 chunks +13 lines, -4 lines 2 comments Download

Messages

Total messages: 8 (4 generated)
Cutch
Committed patchset #1 (id:1) manually as 1020392647d9a6a1a4b71db1c15795fcb7857959 (presubmit successful).
4 years, 6 months ago (2016-06-06 21:51:31 UTC) #4
Cutch
TBR
4 years, 6 months ago (2016-06-06 21:51:31 UTC) #5
zra
DBC https://codereview.chromium.org/2039383002/diff/1/runtime/bin/loader.cc File runtime/bin/loader.cc (right): https://codereview.chromium.org/2039383002/diff/1/runtime/bin/loader.cc#newcode522 runtime/bin/loader.cc:522: Loader* Loader::LoaderForLocked(Dart_Port port) { ASSERT(loader_infos_lock_.IsOwnedByCurrentThread());
4 years, 6 months ago (2016-06-07 04:51:46 UTC) #7
Cutch
4 years, 6 months ago (2016-06-07 14:22:15 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/2039383002/diff/1/runtime/bin/loader.cc
File runtime/bin/loader.cc (right):

https://codereview.chromium.org/2039383002/diff/1/runtime/bin/loader.cc#newco...
runtime/bin/loader.cc:522: Loader* Loader::LoaderForLocked(Dart_Port port) {
On 2016/06/07 04:51:46, zra wrote:
> ASSERT(loader_infos_lock_.IsOwnedByCurrentThread());

The threads interface under bin/ does not have IsOwnedByCurrentThread.

Powered by Google App Engine
This is Rietveld 408576698