chrome/browser/page_load_metrics/page_load_metrics_observer.h - Issue 2039363003: FirstMeaningfulPaint UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.h

Issue 2039363003: FirstMeaningfulPaint UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.h b/chrome/browser/page_load_metrics/page_load_metrics_observer.h

index 52e282644676b2e1e5ffd47a0ebeddc3adac33b1..6054e62844bf047ce4935ff54ea4fd45c849a2e1 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.h

@@ -176,6 +176,8 @@ class PageLoadMetricsObserver {

const PageLoadExtraInfo& extra_info) {}

virtual void OnFirstContentfulPaint(const PageLoadTiming& timing,

const PageLoadExtraInfo& extra_info) {}

+ virtual void OnFirstMeaningfulPaint(const PageLoadTiming& timing,

+ const PageLoadExtraInfo& extra_info) {}

virtual void OnParseStart(const PageLoadTiming& timing,

const PageLoadExtraInfo& extra_info) {}

virtual void OnParseStop(const PageLoadTiming& timing,