Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2379)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2039363003: FirstMeaningfulPaint UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
index 769c89f7538fed43082b614fa8706e7f12994e94..899a376599a00b3ba68960bef2e0956de4f53b85 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
@@ -548,3 +548,52 @@ TEST_F(CorePageLoadMetricsObserverTest, NewNavigation) {
internal::kHistogramLoadTypeParseStartNewNavigation,
timing.parse_start.value().InMilliseconds(), 1);
}
+
+TEST_F(CorePageLoadMetricsObserverTest, FirstMeaningfulPaint) {
+ page_load_metrics::PageLoadTiming timing;
+ timing.navigation_start = base::Time::FromDoubleT(1);
+ timing.parse_start = base::TimeDelta::FromMilliseconds(5);
+ timing.first_meaningful_paint = base::TimeDelta::FromMilliseconds(10);
+ PopulateRequiredTimingFields(&timing);
+
+ NavigateAndCommit(GURL(kDefaultTestUrl));
+ SimulateTimingUpdate(timing);
+ NavigateAndCommit(GURL(kDefaultTestUrl2));
+
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramFirstMeaningfulPaint, 1);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramParseStartToFirstMeaningfulPaint, 1);
+ histogram_tester().ExpectBucketCount(
+ internal::kHistogramFirstMeaningfulPaintStatus,
+ internal::FMP_RECORDED, 1);
+}
+
+TEST_F(CorePageLoadMetricsObserverTest, FirstMeaningfulPaintAfterInteraction) {
+ page_load_metrics::PageLoadTiming timing;
+ timing.navigation_start = base::Time::FromDoubleT(1);
+ timing.parse_start = base::TimeDelta::FromMilliseconds(5);
+ timing.first_paint = base::TimeDelta::FromMilliseconds(10);
+ PopulateRequiredTimingFields(&timing);
+
+ NavigateAndCommit(GURL(kDefaultTestUrl));
+ SimulateTimingUpdate(timing);
+
+ blink::WebMouseEvent mouse_event;
+ mouse_event.type = blink::WebInputEvent::MouseDown;
+ SimulateInputEvent(mouse_event);
+
+ timing.first_meaningful_paint = base::TimeDelta::FromMilliseconds(1000);
+ PopulateRequiredTimingFields(&timing);
+ SimulateTimingUpdate(timing);
+
+ NavigateAndCommit(GURL(kDefaultTestUrl2));
+
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramFirstMeaningfulPaint, 0);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramParseStartToFirstMeaningfulPaint, 0);
+ histogram_tester().ExpectBucketCount(
+ internal::kHistogramFirstMeaningfulPaintStatus,
+ internal::FMP_USER_INTERACTION_BEFORE_FMP, 1);
+}

Powered by Google App Engine
This is Rietveld 408576698