Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2189)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2039363003: FirstMeaningfulPaint UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index f34a99596684586f6fd870b85392677e2762b6e4..a958102eea30ab75a7e6b3c9fd742322c9a69aa6 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -176,6 +176,13 @@ bool IsValidPageLoadTiming(const PageLoadTiming& timing) {
return false;
}
+ if (!EventsInOrder(timing.first_paint, timing.first_meaningful_paint)) {
+ NOTREACHED() << "Invalid first_paint " << timing.first_paint
+ << " for first_meaningful_paint "
+ << timing.first_meaningful_paint;
+ return false;
+ }
+
return true;
}
@@ -235,6 +242,8 @@ void DispatchObserverTimingCallbacks(PageLoadMetricsObserver* observer,
observer->OnFirstImagePaint(new_timing, extra_info);
if (new_timing.first_contentful_paint && !last_timing.first_contentful_paint)
observer->OnFirstContentfulPaint(new_timing, extra_info);
+ if (new_timing.first_meaningful_paint && !last_timing.first_meaningful_paint)
+ observer->OnFirstMeaningfulPaint(new_timing, extra_info);
if (new_timing.parse_start && !last_timing.parse_start)
observer->OnParseStart(new_timing, extra_info);
if (new_timing.parse_stop && !last_timing.parse_stop)

Powered by Google App Engine
This is Rietveld 408576698