chrome/common/page_load_metrics/page_load_timing.h - Issue 2039363003: FirstMeaningfulPaint UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/page_load_metrics/page_load_timing.h

Issue 2039363003: FirstMeaningfulPaint UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/page_load_metrics/page_load_timing.h

diff --git a/chrome/common/page_load_metrics/page_load_timing.h b/chrome/common/page_load_metrics/page_load_timing.h

index e41235b49f8f8e6805307f3ba47ae4b5447b2443..25697faa0b8fa95612ff3ffca985fbaf1b9a334a 100644

--- a/chrome/common/page_load_metrics/page_load_timing.h

+++ b/chrome/common/page_load_metrics/page_load_timing.h

@@ -52,6 +52,8 @@ struct PageLoadTiming {

base::Optional<base::TimeDelta> first_image_paint;

// Time when the first contentful thing (image, text, etc.) is painted.

base::Optional<base::TimeDelta> first_contentful_paint;

+ // Time when the page's primary content is painted.

Charlie Harrison 2016/08/04 02:18:29 If this is experimental can you document that here

Kunihiko Sakamoto 2016/08/04 02:56:14 Done.

+ base::Optional<base::TimeDelta> first_meaningful_paint;

// Time that the document's parser started and stopped parsing main resource

// content.