chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc - Issue 2039363003: FirstMeaningfulPaint UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 2039363003: FirstMeaningfulPaint UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ignore interactions before FP Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('K') | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/page_load_metrics_observer.h » ('j') | chrome/common/page_load_metrics/page_load_timing.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

index b1c61b20c923fb9d6cbd0cf841d64a02209c2a1e..910447af0b5eeaafdcdb2db3a4ef1a11b29f7402 100644

--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

@@ -53,6 +53,9 @@ PageLoadMetricsObserverTestHarness::~PageLoadMetricsObserverTestHarness() {}

// static

void PageLoadMetricsObserverTestHarness::PopulateRequiredTimingFields(

PageLoadTiming* inout_timing) {

+ if (inout_timing->first_meaningful_paint && !inout_timing->first_paint) {

+ inout_timing->first_paint = inout_timing->first_meaningful_paint;

+ }

if (inout_timing->first_contentful_paint && !inout_timing->first_paint) {

inout_timing->first_paint = inout_timing->first_contentful_paint;

}