Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

Issue 2039363003: FirstMeaningfulPaint UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ignore interactions before FP Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
index b33bc56863e80e98d66acc8ca3eb944307d07ceb..795510065aba457c0d1500455af7eaef50140e15 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
@@ -77,6 +77,9 @@ class CorePageLoadMetricsObserver
void OnFirstContentfulPaint(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+ void OnFirstMeaningfulPaint(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) override;
void OnParseStart(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
@@ -89,6 +92,8 @@ class CorePageLoadMetricsObserver
const page_load_metrics::FailedProvisionalLoadInfo& failed_load_info,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+ void OnUserInput(const blink::WebInputEvent& event) override;
+
private:
void RecordTimingHistograms(const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info);
@@ -97,6 +102,9 @@ class CorePageLoadMetricsObserver
ui::PageTransition transition_;
bool initiated_by_user_gesture_;
+ bool had_first_paint_;
+ base::TimeTicks navigation_start_;
+ base::TimeTicks first_user_interaction_after_first_paint_;
DISALLOW_COPY_AND_ASSIGN(CorePageLoadMetricsObserver);
};

Powered by Google App Engine
This is Rietveld 408576698