[Android] Ensure perf test runner does not create shards for blacklisted devices.

[Android] Ensure perf test runner does not create shards for blacklisted devices.

BUG=617559
Committed: https://crrev.com/15c70d1120b419bc68a484d8ecce5773433466f0
Cr-Commit-Position: refs/heads/master@{#398197}

[rnephew (Reviews Here), 2016-06-06 21:21:29]

rnephew@chromium.org changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org, perezju@chromium.org

[jbudorick, 2016-06-06 22:52:27]

https://codereview.chromium.org/2039363002/diff/20001/build/android/pylib/bas...
File build/android/pylib/base/test_dispatcher.py (right):

https://codereview.chromium.org/2039363002/diff/20001/build/android/pylib/bas...
build/android/pylib/base/test_dispatcher.py:153: blacklist =
(device_blacklist.Blacklist(blacklist_file).Read()
This isn't the right place to do this; it'll get read on all threads. This
should instead be handled in pylib.perf.setup.Setup, inside the
TestRunnerFactory it returns. I think you can do it by checking if the device is
in active_devices.

[rnephew (Reviews Here), 2016-06-06 23:33:21]

https://codereview.chromium.org/2039363002/diff/20001/build/android/pylib/bas...
File build/android/pylib/base/test_dispatcher.py (right):

https://codereview.chromium.org/2039363002/diff/20001/build/android/pylib/bas...
build/android/pylib/base/test_dispatcher.py:153: blacklist =
(device_blacklist.Blacklist(blacklist_file).Read()
On 2016/06/06 22:52:27, jbudorick wrote:
> This isn't the right place to do this; it'll get read on all threads. This
> should instead be handled in pylib.perf.setup.Setup, inside the
> TestRunnerFactory it returns. I think you can do it by checking if the device
is
> in active_devices.

Yeah, that makes for a much much simpler solution.

[jbudorick, 2016-06-07 00:27:26]

lgtm w/ nit

https://codereview.chromium.org/2039363002/diff/40001/build/android/pylib/bas...
File build/android/pylib/base/test_dispatcher.py (right):

https://codereview.chromium.org/2039363002/diff/40001/build/android/pylib/bas...
build/android/pylib/base/test_dispatcher.py:150: if runner:
Nit: remove the logging from the runner_factory and log something at warning
level in an else block here.

[rnephew (Reviews Here), 2016-06-07 00:40:32]

https://codereview.chromium.org/2039363002/diff/40001/build/android/pylib/bas...
File build/android/pylib/base/test_dispatcher.py (right):

https://codereview.chromium.org/2039363002/diff/40001/build/android/pylib/bas...
build/android/pylib/base/test_dispatcher.py:150: if runner:
On 2016/06/07 00:27:26, jbudorick wrote:
> Nit: remove the logging from the runner_factory and log something at warning
> level in an else block here.

Done.

[rnephew (Reviews Here), 2016-06-07 00:40:35]

The CQ bit was checked by rnephew@chromium.org

[rnephew (Reviews Here), 2016-06-07 00:40:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2039363002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-06-07 00:40:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039363002/60001

[commit-bot: I haz the power, 2016-06-07 02:15:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-07 02:18:56]

Description was changed from

==========
[Android] Ensure perf test runner does not create shards for blacklisted
devices.

BUG=617559
==========

to

==========
[Android] Ensure perf test runner does not create shards for blacklisted
devices.

BUG=617559

Committed: https://crrev.com/15c70d1120b419bc68a484d8ecce5773433466f0
Cr-Commit-Position: refs/heads/master@{#398197}
==========

[commit-bot: I haz the power, 2016-06-07 02:18:58]

Patchset 4 (id:??) landed as
https://crrev.com/15c70d1120b419bc68a484d8ecce5773433466f0
Cr-Commit-Position: refs/heads/master@{#398197}

[rnephew (Reviews Here), 2016-06-13 15:02:40]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2059253002/ by rnephew@chromium.org.

The reason for reverting is: Possibly breaking v8 perf bots..