Create new directory for budget_service

Create new directory for budget_service.

The budget service is going to be expanded in the future.
Rather than pollute the push_messaging directory with the
general purpose budget service, this separates it out into
its own directory.

BUG=617971
Committed: https://crrev.com/fe1b0492f0f91a26fb113bffc37576c2781920de
Cr-Commit-Position: refs/heads/master@{#398518}

[harkness, 2016-06-06 17:24:38]

Description was changed from

==========
Create new directory for budget_service

BUG=602244
==========

to

==========
Create new directory for budget_service.

The budget service is going to be expanded in the future. Rather than pollute
the push_messaging directory with the general purpose budget service, this
separates it out into its own directory.

BUG=602244
==========

[harkness, 2016-06-06 17:24:57]

harkness@chromium.org changed reviewers:
+ peter@chromium.org

[harkness, 2016-06-06 17:25:20]

The CQ bit was checked by harkness@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 17:26:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039283002/1

[commit-bot: I haz the power, 2016-06-06 18:52:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 18:52:02]

Dry run: This issue passed the CQ dry run.

[Peter Beverloo, 2016-06-07 10:02:07]

lgtm, three comments:

  (1) Please wrap the description of your CL (we usually try to limit
      lines to 74 characters).
  (2) There seems to be a discrepancy between the "budget_service"
      directory name and the "background_budget_service" file names. Is
      it worthwhile to keep this?
  (3) We just discussed this, but as case in point— if I were reviewing
      this with no context, does Issue 602244 give me the impression that
      this is a feature that deserves its own directory?

[harkness, 2016-06-07 15:16:10]

Description was changed from

==========
Create new directory for budget_service.

The budget service is going to be expanded in the future. Rather than pollute
the push_messaging directory with the general purpose budget service, this
separates it out into its own directory.

BUG=602244
==========

to

==========
Create new directory for budget_service.

The budget service is going to be expanded in the future. 
Rather than pollute the push_messaging directory with the 
general purpose budget service, this separates it out into 
its own directory.

BUG=617971
==========

[harkness, 2016-06-07 15:18:56]

On 2016/06/07 10:02:07, Peter Beverloo - OOO June 8-16 wrote:
> lgtm, three comments:
> 
>   (1) Please wrap the description of your CL (we usually try to limit
>       lines to 74 characters).
>   (2) There seems to be a discrepancy between the "budget_service"
>       directory name and the "background_budget_service" file names. Is
>       it worthwhile to keep this?
>   (3) We just discussed this, but as case in point— if I were reviewing
>       this with no context, does Issue 602244 give me the impression that
>       this is a feature that deserves its own directory?


(1) Done
(2) I've thought about this a lot today, and I think I'm going to leave the
naming the way it is right now. I want the directory to be the more generic
"budget_service" because I think we may have a lot of expansion in the future,
but while it's possible that expansion will be entirely based on the
BackgroundBudgetService, right now it is a very specialized beast.
(3) New bug filed, updated the description

[harkness, 2016-06-07 15:22:02]

harkness@chromium.org changed reviewers:
+ bauerb@chromium.org, thestig@chromium.org

[harkness, 2016-06-07 15:22:03]

thestig@chromium.org: Please review changes in directory structure for
chrome/browser.

bauerb@chromium.org: Please review changes in
chrome/browser/prefs/browser_prefs.cc

[Bernhard Bauer, 2016-06-07 16:01:43]

prefs/ LGTM; feel free to TBR trivial header moves if the overall change has
been approved.

[Lei Zhang, 2016-06-08 00:31:15]

moving code to a new directory lgtm

Do you want to copy chrome/browser/push_messaging/PRESUBMIT.py over too?

[harkness, 2016-06-08 10:13:03]

Good catch on the PRESUBMIT.py. I copied one over, and checked that it would
catch format errors. Thanks!

[harkness, 2016-06-08 10:15:34]

The CQ bit was checked by harkness@chromium.org

[harkness, 2016-06-08 10:15:35]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org,
thestig@chromium.org, bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2039283002/#ps20001
(title: "Added PRESUMBIT.py")

[commit-bot: I haz the power, 2016-06-08 10:15:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039283002/20001

[commit-bot: I haz the power, 2016-06-08 10:56:43]

Description was changed from

==========
Create new directory for budget_service.

The budget service is going to be expanded in the future. 
Rather than pollute the push_messaging directory with the 
general purpose budget service, this separates it out into 
its own directory.

BUG=617971
==========

to

==========
Create new directory for budget_service.

The budget service is going to be expanded in the future. 
Rather than pollute the push_messaging directory with the 
general purpose budget service, this separates it out into 
its own directory.

BUG=617971
==========

[commit-bot: I haz the power, 2016-06-08 10:56:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-08 10:58:07]

Description was changed from

==========
Create new directory for budget_service.

The budget service is going to be expanded in the future. 
Rather than pollute the push_messaging directory with the 
general purpose budget service, this separates it out into 
its own directory.

BUG=617971
==========

to

==========
Create new directory for budget_service.

The budget service is going to be expanded in the future.
Rather than pollute the push_messaging directory with the
general purpose budget service, this separates it out into
its own directory.

BUG=617971

Committed: https://crrev.com/fe1b0492f0f91a26fb113bffc37576c2781920de
Cr-Commit-Position: refs/heads/master@{#398518}
==========

[commit-bot: I haz the power, 2016-06-08 10:58:11]

Patchset 2 (id:??) landed as
https://crrev.com/fe1b0492f0f91a26fb113bffc37576c2781920de
Cr-Commit-Position: refs/heads/master@{#398518}